Skip to content

Commit 9a86c55

Browse files
committed
build(ohunt): drop xbehave
It is deprecated and can be simply replaced with comments.
1 parent a8ddd20 commit 9a86c55

File tree

4 files changed

+282
-353
lines changed

4 files changed

+282
-353
lines changed

ohunt/OHunt.Tests/Dataflow/CrawlerPropagatorTests.cs

Lines changed: 35 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using OHunt.Web.Crawlers;
77
using OHunt.Web.Dataflow;
88
using OHunt.Web.Models;
9-
using Xbehave;
109
using Xunit;
1110

1211
namespace OHunt.Tests.Dataflow
@@ -26,51 +25,44 @@ public CrawlerPropagatorTests()
2625
_propagator = new CrawlerPropagator(_submissionOutput, _errorOutput);
2726
}
2827

29-
[Scenario]
30-
public void It_ShouldWork()
28+
[Fact]
29+
public async Task It_ShouldWork()
3130
{
32-
"Given a propagator".x(() => { });
33-
34-
"When receiving data"
35-
.x(() => _propagator.SendAsync(new CrawlerMessage
36-
{
37-
Submission = new Submission
38-
{
39-
Status = RunResult.Accepted,
40-
Time = new DateTime(2020, 4, 1, 0, 0, 0),
41-
ProblemLabel = "1001",
42-
SubmissionId = 42,
43-
UserName = "user1",
44-
OnlineJudgeId = OnlineJudge.ZOJ,
45-
},
46-
CrawlerError = new CrawlerError
47-
{
48-
Crawler = "zoj",
49-
Data = null,
50-
Message = "An error",
51-
Time = new DateTime(2020, 4, 1, 1, 0, 0),
52-
},
53-
})
54-
);
55-
56-
"Then they are cached"
57-
.x(async () =>
31+
// Given a propagator
32+
33+
// When receiving data
34+
await _propagator.SendAsync(new CrawlerMessage
35+
{
36+
Submission = new Submission
37+
{
38+
Status = RunResult.Accepted,
39+
Time = new DateTime(2020, 4, 1, 0, 0, 0),
40+
ProblemLabel = "1001",
41+
SubmissionId = 42,
42+
UserName = "user1",
43+
OnlineJudgeId = OnlineJudge.ZOJ,
44+
},
45+
CrawlerError = new CrawlerError
5846
{
59-
await Utils.WaitSecond();
60-
_submissionOutput.Count.Should().Be(0);
61-
_errorOutput.Count.Should().Be(0);
62-
});
47+
Crawler = "zoj",
48+
Data = null,
49+
Message = "An error",
50+
Time = new DateTime(2020, 4, 1, 1, 0, 0),
51+
},
52+
});
6353

64-
"When a checkpoint is sent"
65-
.x(() => _propagator.SendAsync(new CrawlerMessage { Checkpoint = true }));
54+
// Then they are cached
55+
await Utils.WaitSecond();
56+
_submissionOutput.Count.Should().Be(0);
57+
_errorOutput.Count.Should().Be(0);
6658

67-
"Then data are dispatched"
68-
.x(async () =>
69-
{
70-
await Utils.WaitSecond();
71-
_submissionOutput.Count.Should().Be(1);
72-
_errorOutput.Count.Should().Be(1);
73-
});
59+
// When a checkpoint is sent
60+
await _propagator.SendAsync(new CrawlerMessage { Checkpoint = true });
61+
62+
// Then data are dispatched
63+
await Utils.WaitSecond();
64+
_submissionOutput.Count.Should().Be(1);
65+
_errorOutput.Count.Should().Be(1);
7466
}
7567

7668
[Fact]
@@ -107,7 +99,7 @@ await _propagator.SendAsync(new CrawlerMessage
10799
await _propagator.SendAsync(new CrawlerMessage
108100
{
109101
Submission = new Submission
110-
{
102+
{
111103
SubmissionId = 4,
112104
},
113105
Checkpoint = true,

0 commit comments

Comments
 (0)