users cannot open pending chats that have user_id==0

[alonsoac]

I see in modules/lhchat/adminchat.php :

        if ($chat->status == erLhcoreClassModelChat::STATUS_PENDING_CHAT && $chat->user_id != $userData->id && !$currentUser->hasAccessTo('lhchat','open_all')) {
            throw new Exception('You do not have permission to open all pending chats.');
        }

This is preventing users from opening pending chats that have no assigned user.

The code and the error message are confusing because the open_all permission is described as "Allow operator to open all chats, not only assigned to him". It does not mention pending chats and one would assume this allows to open chats in any status. Also one would not assume that this permission is needed to open pending chats that are unassigned.

The problem is that giving the open_all permission then allows users to open pending chats that are assigned to other users and we do not want this.

[remdex]

Read...
https://doc.livehelperchat.com/docs/chat#permissions-influencing-chat-opening-permissions

[alonsoac]

This still does not explain why the program would let the user see the chats but not open them.

most of our customers do not like auto assignment. For this particular customer we programmed assignment of some chats to users if the visitor is recognized. But others remain unassigned.

[remdex]

I see. I improve docs explain and add new permission if I see it's required

[remdex]

Related changes with new permission just for that scenario which will allow to open pending chat/mail if it was not assigned yet.
0354e32

[remdex]

As for resume chat listing and chat opening are different permissions. Just for future reference.

Chat listing permissions are explained here.
https://doc.livehelperchat.com/docs/chat/list

Chat opening permissions section was updated.
https://doc.livehelperchat.com/docs/chat/#permissions-influencing-chat-opening-permissions

[remdex]

This still does not explain why the program would let the user see the chats but not open them.

most of our customers do not like auto assignment. For this particular customer we programmed assignment of some chats to users if the visitor is recognized. But others remain unassigned.

And for this you did not needed to program anything you just had to use already existing function. E.g you set variable that customer is registered and then in auto assigned check for presence of this var. Only those chats would be auto assigned :)