Fixed reset not considering the message's argument (#1110)

Before this, LiveSplitOne would not consider the server's "saveAttempt" argument when receiving a reset command. This makes sure the command is full taken into account, by asking the user if they wish to save the times if and only if the command has not provided the "saveAttempt" argument.

Author: Paloys

src/ui/views/TimerView.tsx

@@ -180,7 +180,7 @@ function View({
                         <button
                             aria-label="Reset"
                             disabled={currentPhase === TimerPhase.NotRunning}
-                            onClick={(_) => commandSink.reset()}
+                            onClick={(_) => commandSink.reset(undefined)}
                         >
                             <X strokeWidth={3.5} />
                         </button>

src/util/LSOCommandSink.ts

@@ -111,13 +111,12 @@ export class LSOCommandSink {
         return result;
     }
 
-    public async reset(): Promise<CommandResult> {
+    public async reset(updateSplits?: boolean): Promise<CommandResult> {
         if (this.locked) {
             return CommandError.Busy;
         }
 
-        let updateSplits = true;
-        if (this.timer.currentAttemptHasNewBestTimes()) {
+        if (updateSplits === undefined && this.timer.currentAttemptHasNewBestTimes()) {
             const [result] = await showDialog({
                 title: "Save Best Times?",
                 description:
@@ -130,7 +129,7 @@ export class LSOCommandSink {
             updateSplits = result === 0;
         }
 
-        const result = this.timer.reset(updateSplits) as CommandResult;
+        const result = this.timer.reset(updateSplits ?? true) as CommandResult;
 
         if (isEvent(result)) {
             this.callbacks.handleEvent(result);