Merge branch 'gh-pages' of https://github.com/LivelyKernel/lively4-core into gh-pages

Author: onsetsu

doc/journal/2020-11-30.md/index.md

@@ -0,0 +1,22 @@
+## 2020-11-30 #Server #Testing #Issue
+*Author: @JensLincke*
+
+
+## How to Automate this Test?
+
+1. Setup:
+```javascript
+lively.files.saveFile("http://localhost:9006/Dropbox/Thesis/Literature/_misc/foo.md", "test content")
+```
+
+2. Test:
+```javascript
+fetch("http://localhost:9006/Dropbox/Thesis/Literature/_misc/foo.md", {
+        method: "MOVE",
+        headers: {
+          destination: "http://localhost:9006/Dropbox/Thesis/Literature/_misc/" + encodeURI("foo―é.md")
+        }
+      }).then(r => r.text())
+```
+
+3. check that there is not error... and the file is there?

src/client/bibliography.js

@@ -104,7 +104,7 @@ Bibliography.cleanTitle("{{This is my Title}}")
   MD*/
 
   static cleanTitle(titleString="") {
-     return titleString.replace(/[{}]/g,"").replace(/[—]/g," ")
+     return titleString.replace(/[{}:\[\]]/g,"").replace(/[—]/g," ")
   }
 
   // #TODO this method obviously will need a lot of tweaking...

src/components/tools/literature-listing.js

@@ -65,7 +65,7 @@ export default class LiteratureListing extends Morph {
     // reset entries
     this.literatureFiles.forEach(literatureFile => literatureFile.entry = null)
 
-    entries.forEach(entry => {
+    await entries.forEach(entry => {
       this.literatureFiles.filter(ea => ea.key == entry.key).forEach(literatureFile => {
         literatureFile.entry = entry
       })
@@ -172,6 +172,7 @@ export default class LiteratureListing extends Morph {
   }
 
   renderLiteratureFile(literatureFile) {
+    debugger
     var entryDetails = literatureFile.entry ? 
         <span>
           <span class="authors">{literatureFile.entry.authors.join(", ")}</span>.

src/components/tools/lively-container.js

@@ -831,13 +831,13 @@ export default class Container extends Morph {
   async renameFile(url, followFile=true, proposedNewName) {
     url = "" + url
     var base = url.replace(/[^/]*$/,"")
-    var name = proposedNewName || url.replace(/.*\//,"")
+    var name = proposedNewName || decodeURI(url.replace(/.*\//,""))
     var newName = await lively.prompt("rename", name)
     if (!newName) {
       lively.notify("cancel rename " + name)
       return
     }
-    var newURL = base + newName
+    var newURL = base + encodeURI(newName)
     if (newURL != url) {
       await files.moveFile(url, newURL)
 

test/bibliography-test.js

@@ -215,6 +215,14 @@ describe('Bibliography', () => {
       expect(key).to.equal("Guenter1998ECC")  
     });
 
+    it('stripps colon', async function() {
+      var key = Bibliography.generateCitationKey({entryTags: {
+        author: `Ken Perlin and Zhenyi He and Karl Rosenberg`,
+        year: 2018,
+        title: "Chalktalk : A Visualization and Communication Language -- As a Tool in the Domain of Computer Science Education",
+      }})
+      expect(key).to.equal("Perlin2018CVC")
+    });  
   })
 
 });