AEDebugging_ Deregister closed codemirrors properly

Markus-Brand · Markus-Brand · commit 268e67f982fd · 2021-03-02T13:49:24.000+01:00
SQUASHED: AUTO-COMMIT-src-client-reactive-active-expression-rewriting-active-expression-rewriting.js,AUTO-COMMIT-src-components-widgets-lively-code-mirror.js,
diff --git a/src/client/reactive/active-expression-rewriting/active-expression-rewriting.js b/src/client/reactive/active-expression-rewriting/active-expression-rewriting.js
@@ -347,6 +347,7 @@ export class AEDebuggingCache {
   async updateDebggingViews() {
     for (let i = 0; i < this.registeredDebuggingViews.length; i++) {
       if (![...this.changedFiles].some(file => file.includes(this.registeredDebuggingViews[i].url))) continue;
+      debugger;
       if (!(await this.registeredDebuggingViews[i].callback())) {
         this.registeredDebuggingViews.splice(i, 1);
         i--;
diff --git a/src/components/widgets/lively-code-mirror.js b/src/components/widgets/lively-code-mirror.js
@@ -1592,7 +1592,7 @@ export default class LivelyCodeMirror extends HTMLElement {
   }
   
   valid() {
-    return !!lively.query(this, "lively-container");
+    return lively.allParents(this, [], true).includes(document.body);
   }
 
   drawAExprGutter(line, dependencies, isAE) {

Original file line number	Diff line number	Diff line change
`@@ -1592,7 +1592,7 @@ export default class LivelyCodeMirror extends HTMLElement {`
`1592`	`1592`	`}`
`1593`	`1593`
`1594`	`1594`	`valid() {`
`1595`		`- return !!lively.query(this, "lively-container");`
	`1595`	`+ return lively.allParents(this, [], true).includes(document.body);`
`1596`	`1596`	`}`
`1597`	`1597`
`1598`	`1598`	`drawAExprGutter(line, dependencies, isAE) {`