Skip to content

Commit 49f598c

Browse files
committed
AEDebugging_ Better event ids
SQUASHED: AUTO-COMMIT-src-client-reactive-active-expression-active-expression.js,AUTO-COMMIT-src-client-reactive-active-expression-rewriting-active-expression-rewriting.js,AUTO-COMMIT-src-client-reactive-components-basic-aexpr-timeline.js,
1 parent 41e5a52 commit 49f598c

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

src/client/reactive/active-expression-rewriting/active-expression-rewriting.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -836,10 +836,6 @@ export class RewritingActiveExpression extends BaseActiveExpression {
836836
super(func, ...args);
837837
this.meta({ strategy: 'Rewriting' });
838838
this.updateDependencies();
839-
840-
if (new.target === RewritingActiveExpression) {
841-
this.addToRegistry();
842-
}
843839
}
844840

845841
dispose() {

src/client/reactive/active-expression/active-expression.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,7 @@ export class BaseActiveExpression {
214214

215215
this.initializeEvents();
216216

217-
if (new.target === BaseActiveExpression) {
218-
this.addToRegistry();
219-
}
217+
this.addToRegistry();
220218
this.logEvent('created', {ae: this, stack: lively.stack(), value: "no value yet"});
221219
}
222220

@@ -582,7 +580,7 @@ export class BaseActiveExpression {
582580
//if(!this.meta().has('events'))this.meta({events : new Array()});
583581
let events = this.meta().get('events');
584582
const timestamp = new Date();
585-
const event = { timestamp , type, value, id: (this.meta().get('id') || 0) + timestamp.getTime() };
583+
const event = { timestamp , type, value, id: this.meta().get('id') + "-" + events.length };
586584
AExprRegistry.eventListeners().forEach(listener => listener.callback(this, event));
587585
events.push(event);
588586
if (events.length > 5000) events.shift();

src/client/reactive/components/basic/aexpr-timeline.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export default class EventDrops extends Morph {
2121
bound: { format: () => undefined },
2222
range: { start: new Date(performance.timeOrigin), end: new Date() },
2323
line: {
24+
height: 25,
2425
color: (_, index) => d3.schemeCategory10[index % 10]
2526
},
2627
zoom: {

0 commit comments

Comments
 (0)