Skip to content

Conversation

@Freakness109
Copy link
Contributor

Description

Switch from calling make directly to using cmake.
This allows for other cmake generators, such as ninja, without needing to change the PKGBUILD to use them:
Exporting the standard CMAKE_GENERATOR env variable is enough to change it.
Previously, having the variable exported broke the build script, so tagging as bugfix (but feel free to change to feature).

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project (as far as I can tell)
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8076160). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4579   +/-   ##
=========================================
  Coverage          ?   15.42%           
=========================================
  Files             ?       93           
  Lines             ?    19016           
  Branches          ?     8767           
=========================================
  Hits              ?     2934           
  Misses            ?    14436           
  Partials          ?     1646           
Flag Coverage Δ
Archlinux 11.54% <ø> (?)
FreeBSD-14.3-amd64 13.82% <ø> (?)
Homebrew-ubuntu-22.04 13.83% <ø> (?)
Linux-AppImage 11.85% <ø> (?)
Windows-AMD64 13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Bundle Report

Bundle size has no change ✅

This allows for other cmake generators, such as ninja, without needing
to change the PKGBUILD to use them
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit 6400522 into LizardByte:master Jan 16, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants