Skip to content

Conversation

cgutman
Copy link
Contributor

@cgutman cgutman commented Aug 10, 2025

Description

This updates FFmpeg to the new 8.0 release branch. I got all of our AMF and NVENC patches upstreamed for FFmpeg 8.0, however a bug was introduced during the upstream AMF rewrite that requires a new patch.

This will require a corresponding change to Sunshine to address some build issues and option names that changed during the upstreaming process.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@cgutman
Copy link
Contributor Author

cgutman commented Aug 10, 2025

Testing is complete on all platforms so this should be good to go.

@ReenigneArcher ReenigneArcher merged commit ac6c660 into LizardByte:master Aug 10, 2025
19 checks passed
@Rongronggg9
Copy link

Rongronggg9 commented Aug 26, 2025

Recent nightly versions of Sunshine break VA-API HEVC encoding on RDNA3.5, resulting in an extra green bar at the bottom. I did not bisect, but I guess this was because [PATCH] avcodec/vaapi_encode: add customized surface alignment was dropped in this PR.

@Rongronggg9
Copy link

I did not bisect, but I guess this is because [PATCH] avcodec/vaapi_encode: add customized surface alignment is dropped in this PR.

Confirmed that https://github.com/LizardByte/Sunshine/actions/runs/16784617469 is the last good (successful) build and https://github.com/LizardByte/Sunshine/actions/runs/16966842290 is the first bad (successful) build, where LizardByte/Sunshine#4143 was merged in between.

@inkatail
Copy link

I did not bisect, but I guess this is because [PATCH] avcodec/vaapi_encode: add customized surface alignment is dropped in this PR.

Confirmed that https://github.com/LizardByte/Sunshine/actions/runs/16784617469 is the last good (successful) build and https://github.com/LizardByte/Sunshine/actions/runs/16966842290 is the first bad (successful) build, where LizardByte/Sunshine#4143 was merged in between.

This also happens on my RX 6600 (RDNA 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants