Skip to content

Commit e9ed38e

Browse files
Update CI dependencies and tidy tray_linux.c includes
Added 'xfce4-notifyd' and 'indicator-application' to CI dependencies for improved test coverage. Cleaned up and reordered standard includes in tray_linux.c for clarity. Minor comment capitalization fix in ci_linux_desktop.sh.
1 parent aabd2c0 commit e9ed38e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ jobs:
7070
xfce4 \
7171
xfce4-panel \
7272
xfce4-indicator-plugin \
73+
xfce4-notifyd \
74+
indicator-application \
7375
xfconf \
7476
xkb-data \
7577
imagemagick \

.github/workflows/ci_linux_desktop.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ mkdir -p "${XDG_DATA_HOME}"
2323
chmod 700 "${XDG_DATA_HOME}"
2424

2525
cleanup() {
26-
# best effort cleanup
26+
# Best-effort cleanup.
2727
kill "${WATCHER_PID:-}" "${PANEL_PID:-}" "${WM_PID:-}" >/dev/null 2>&1 || true
2828
chmod -R u+w "${XDG_DATA_HOME}" >/dev/null 2>&1 || true
2929
}

src/tray_linux.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@
44
*/
55
// standard includes
66
#include <stdbool.h>
7+
#include <stdio.h>
78
#include <stddef.h>
89
#include <string.h>
10+
#include <unistd.h>
911

1012
// lib includes
1113
#ifdef TRAY_AYATANA_APPINDICATOR
@@ -18,9 +20,6 @@
1820
#endif
1921
#include <libnotify/notify.h>
2022

21-
#include <stdio.h>
22-
#include <unistd.h>
23-
2423
// Use a per-process AppIndicator id to avoid DBus collisions when tests create multiple
2524
// tray instances in the same desktop/session.
2625
static unsigned long tray_appindicator_seq = 0;

0 commit comments

Comments
 (0)