make location request more user intuitive

Author: johnnzhou

app/src/main/java/com/lcl/lclmeasurementtool/MainActivity.java

@@ -37,7 +37,7 @@ protected void onCreate(Bundle savedInstanceState) {
         mCellularManager = CellularManager.getManager(this);
         mLocationManager = LocationServiceManager.getManager(this);
 
-        locationServiceListener = new LocationServiceListener(this);
+        locationServiceListener = new LocationServiceListener(this, getLifecycle());
         getLifecycle().addObserver(locationServiceListener);
 
         TextView tv = (TextView) findViewById(R.id.signalStrengthStatus);

app/src/main/java/com/lcl/lclmeasurementtool/Managers/LocationServiceListener.java

@@ -28,14 +28,21 @@ public class LocationServiceListener implements LifecycleObserver {
     // the context of the Application
     private final Context context;
 
+    // the life cycle object
+    private final Lifecycle lifecycle;
+
+    // the lock that controls the check on location mode
+    private boolean checkLocationModeLock = false;
+
     /**
      * Initialize a LocationService Listener using the current context of the Application
      *
      * @param context the context of the application
      */
-    public LocationServiceListener(@NonNull Context context) {
+    public LocationServiceListener(@NonNull Context context, Lifecycle lifecycle) {
         this.context = context;
         this.mLocationManager = LocationServiceManager.getManager(context);
+        this.lifecycle = lifecycle;
     }
 
 
@@ -54,12 +61,16 @@ void checkLocationPermission() {
      */
     @OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
     void checkLocationMode() {
-        if (!mLocationManager.isLocationModeOn()) {
-
+        if (!mLocationManager.isLocationModeOn() && lifecycle.getCurrentState().equals(Lifecycle.State.RESUMED) && !checkLocationModeLock) {
+            System.out.println(1);
+            checkLocationModeLock = true;
             // TODO turn off start FAB if canceled
             UIUtils.showDialog(context, R.string.location_message_title, R.string.enable_location_message,
                     R.string.go_to_setting,
-                    (paramDialogInterface, paramInt) -> context.startActivity(new Intent(Settings.ACTION_LOCATION_SOURCE_SETTINGS)),
+                    (paramDialogInterface, paramInt) -> {
+                        context.startActivity(new Intent(Settings.ACTION_LOCATION_SOURCE_SETTINGS));
+                        checkLocationModeLock = false;
+                    },
                     android.R.string.cancel,
                     null);
         }

app/src/main/res/values/strings.xml

@@ -9,11 +9,11 @@
 
     <string name="hello_first_fragment">Hello first fragment</string>
     <string name="hello_second_fragment">Hello second fragment. Arg: %1$s</string>
-    <string name="permission_rationale">Location Service should be enabled for core functionality</string>
-    <string name="permission_denied_explanation">Permission was denied, but is needed for core functionality</string>
+    <string name="permission_rationale">"We use Location Service to provide more accurate core network measurement and other related service. Granting the permission of the location service will help us improve our service. We will upload anonymized and fused location data to our encrypted server for post-analysis to better network experience."</string>
     <string name="settings">Settings</string>
     <string name="no_location_detected">No location detected</string>
-    <string name="enable_location_message">Enable Location</string>
+    <string name="enable_location_message">The core functionality relies on location to provide better cellular network experience. Disabling the location service will result in missing in functionality.</string>
     <string name="go_to_setting">Settings</string>
     <string name="location_message_title">Using Location Service</string>
+    <string name="permission_denied_explanation">"We use Location Service to provide core functionalities in this measurement tool. Disabling location service will result in missing in functionality."</string>
 </resources>