fixing attachment upload bug in the imap threader

Author: Paul Philion

redmine/model.py

@@ -25,10 +25,6 @@ def __init__(self, name:str, content_type:str, payload):
         self.payload = payload
         self.token = None
 
-    def upload(self, client, user):
-        # FIXME This is messy, move to caller.
-        self.token = client.ticket_mgr.upload_file(user, self.payload, self.name, self.content_type)
-
     def set_token(self, token):
         self.token = token
 

threader/imap.py

@@ -204,10 +204,7 @@ def handle_message(self, msg_id:str, message:Message):
             log.info(f"Unknow user: {addr}, created new account.")
 
         #  upload any attachments
-        for attachment in message.attachments:
-            # uploading the attachment this way
-            # puts the token in the attachment
-            attachment.upload(self.redmine, user.login)
+        self.ticket_mgr.upload_attachment(user, message.attachments)
 
         if ticket:
             # found a ticket, append the message