Plugin repository optimizations #92
Annotations
1 error and 30 warnings
|
Build Application - Release
Process completed with exit code 1.
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L192
Modify 'GetTimestamp' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L164
The behavior of 'string.EndsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.GetTimestamp(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.EndsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L159
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.GetTimestamp(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L90
The behavior of 'string.EndsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.SplitLine(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.EndsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L154
In member DateTime GlassfishColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine logLine), change parameter name logLine to line in order to match the identifier as it has been declared in DateTime ILogLineColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine line) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L85
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.SplitLine(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build Application - Debug:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L111
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.SplitLine(ILogLineColumnizerCallback, ILogLine)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build Application - Debug:
src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build Application - Debug:
src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build Application - Debug:
src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
|
|
Build Application - Release:
src/LogExpert.Core/Entities/BookmarkCollection.cs#L5
Rename LogExpert.Core.Entities.BookmarkCollection to end in 'List' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1710)
|
|
Build Application - Release:
src/LogExpert.Core/Interface/IBookmarkView.cs#L13
Because property LineColumnVisible is write-only, either add a property getter with an accessibility that is greater than or equal to its setter or convert this property into a method (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1044)
|
|
Build Application - Release:
src/LogExpert.Core/Interface/IBackgroundProcessCancelHandler.cs#L1
Rename namespace LogExpert.Core.Interface so that it no longer conflicts with the reserved language keyword 'Interface'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
|
Build Application - Release:
src/LogExpert.Core/Config/SettingsFlags.cs#L6
Rename type name SettingsFlags so that it does not end in 'Flags' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
|
Build Application - Release:
src/LogExpert.Core/EventArguments/LoadFileEventArgs.cs#L3
Rename type name LoadFileEventArgs so that it does not end in 'EventArgs' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
|
Build Application - Release:
src/LogExpert.Core/EventArguments/CurrentHighlightGroupChangedEventArgs.cs#L6
Rename type name CurrentHighlightGroupChangedEventArgs so that it does not end in 'EventArgs' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
|
Build Application - Release:
src/LogExpert.Core/Config/ExportImportFlags.cs#L4
Rename type name ExportImportFlags so that it does not end in 'Flags' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
|
Build Application - Release:
src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build Application - Release:
src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build Application - Release:
src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
|
|
Build Application - Release:
src/JsonColumnizer/JsonColumnizer.cs#L162
In externally visible method 'JObject JsonColumnizer.ParseJson(ILogLine line)', validate parameter 'line' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Build Application - Release:
src/JsonColumnizer/JsonColumnizer.cs#L148
In externally visible method 'Priority JsonColumnizer.GetPriority(string fileName, IEnumerable<ILogLine> samples)', validate parameter 'fileName' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Build Application - Release:
src/JsonColumnizer/JsonColumnizer.cs#L169
Do not nest type ColumnWithName. Alternatively, change its accessibility so that it is not externally visible. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1034)
|
|
Build Application - Release:
src/FlashIconHighlighter/Win32Stuff.cs#L25
The method FlashWindowEx didn't use DefaultDllImportSearchPaths attribute for P/Invokes. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5392)
|
|
Build Application - Release:
src/FlashIconHighlighter/Win32Stuff.cs#L20
Type 'Win32Stuff' is a static holder type but is neither static nor NotInheritable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1052)
|
|
Build Application - Release:
src/FlashIconHighlighter/Win32Stuff.cs#L11
FLASHWINFO should override the equality (==) and inequality (!=) operators (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
|
|
Build Application - Release:
src/FlashIconHighlighter/Win32Stuff.cs#L11
FLASHWINFO should override Equals (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
|
|
Build Application - Release:
src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build Application - Release:
src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build Application - Release:
src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
Snapshot-Debug
Expired
|
8.18 MB |
sha256:68ea7a090cc6950ed1a277a92a7487ecbfda520bc61fddbf17e9f86534c43842
|
|