Skip to content

optimizations

optimizations #114

Triggered via pull request November 26, 2025 16:04
Status Success
Total duration 2m 43s
Artifacts 2

build_dotnet.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

30 warnings
Build Application - Debug: src/JsonColumnizer/JsonColumnizer.cs#L30
In externally visible method 'void JsonColumnizer.Selected(ILogLineColumnizerCallback callback)', validate parameter 'callback' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build Application - Debug: src/JsonColumnizer/JsonColumnizer.cs#L163
Do not nest type ColumnWithName. Alternatively, change its accessibility so that it is not externally visible. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1034)
Build Application - Debug: src/GlassfishColumnizer/GlassfishColumnizer.cs#L159
In member DateTime GlassfishColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine logLine), change parameter name logLine to line in order to match the identifier as it has been declared in DateTime ILogLineColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine line) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
Build Application - Debug: src/AutoColumnizer/AutoColumnizer.cs#L5
The type name AutoColumnizer conflicts in whole or in part with the namespace name 'AutoColumnizer'. Change either name to eliminate the conflict. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1724)
Build Application - Debug: src/FlashIconHighlighter/Win32Stuff.cs#L10
FLASHWINFO should override the equality (==) and inequality (!=) operators (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
Build Application - Debug: src/FlashIconHighlighter/Win32Stuff.cs#L10
FLASHWINFO should override Equals (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
Build Application - Debug: src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Build Application - Debug: src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Build Application - Debug: src/ColumnizerLib/Column.cs#L56
Non-nullable property 'FullValue' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier, or declaring the property as nullable, or safely handling the case where 'field' is null in the 'get' accessor.
Build Application - Debug: src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
Build Application - Release: src/LogExpert.Core/Interface/IBookmarkView.cs#L13
Because property LineColumnVisible is write-only, either add a property getter with an accessibility that is greater than or equal to its setter or convert this property into a method (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1044)
Build Application - Release: src/LogExpert.Core/Interface/IBackgroundProcessCancelHandler.cs#L1
Rename namespace LogExpert.Core.Interface so that it no longer conflicts with the reserved language keyword 'Interface'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
Build Application - Release: src/LogExpert.Core/EventArguments/LoadFileEventArgs.cs#L3
Rename type name LoadFileEventArgs so that it does not end in 'EventArgs' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
Build Application - Release: src/LogExpert.Core/EventArguments/CurrentHighlightGroupChangedEventArgs.cs#L6
Rename type name CurrentHighlightGroupChangedEventArgs so that it does not end in 'EventArgs' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
Build Application - Release: src/LogExpert.Core/Config/ExportImportFlags.cs#L4
Rename type name ExportImportFlags so that it does not end in 'Flags' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
Build Application - Release: src/LogExpert.Core/Classes/Persister/Persister.cs#L293
'PersisterXML' is obsolete: 'XML persistence is deprecated and will be removed in future versions. This is a fallback for older Versions'
Build Application - Release: src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Build Application - Release: src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Build Application - Release: src/ColumnizerLib/Column.cs#L56
Non-nullable property 'FullValue' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier, or declaring the property as nullable, or safely handling the case where 'field' is null in the 'get' accessor.
Build Application - Release: src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
Build Application - Release: src/JsonColumnizer/JsonColumnizer.cs#L142
In externally visible method 'Priority JsonColumnizer.GetPriority(string fileName, IEnumerable<ILogLine> samples)', validate parameter 'fileName' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build Application - Release: src/JsonColumnizer/JsonColumnizer.cs#L30
In externally visible method 'void JsonColumnizer.Selected(ILogLineColumnizerCallback callback)', validate parameter 'callback' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build Application - Release: src/JsonColumnizer/JsonColumnizer.cs#L107
In externally visible method 'IColumnizedLogLine JsonColumnizer.SplitLine(ILogLineColumnizerCallback callback, ILogLine line)', validate parameter 'line' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build Application - Release: src/JsonColumnizer/JsonColumnizer.cs#L163
Do not nest type ColumnWithName. Alternatively, change its accessibility so that it is not externally visible. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1034)
Build Application - Release: src/GlassfishColumnizer/GlassfishColumnizer.cs#L159
In member DateTime GlassfishColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine logLine), change parameter name logLine to line in order to match the identifier as it has been declared in DateTime ILogLineColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine line) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
Build Application - Release: src/AutoColumnizer/AutoColumnizer.cs#L5
The type name AutoColumnizer conflicts in whole or in part with the namespace name 'AutoColumnizer'. Change either name to eliminate the conflict. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1724)
Build Application - Release: src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Build Application - Release: src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Build Application - Release: src/ColumnizerLib/Column.cs#L56
Non-nullable property 'FullValue' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier, or declaring the property as nullable, or safely handling the case where 'field' is null in the 'get' accessor.
Build Application - Release: src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).

Artifacts

Produced during runtime
Name Size Digest
Snapshot-Debug Expired
9.73 MB
sha256:70031679b818cba4cdf7f549e264187926533c618d7c705cb170cd6dc69a0c56
Snapshot-Release Expired
9.66 MB
sha256:69b95963e3c6fc9da33b96f597981a82fb2afd0fdddc8a71300a86e82d9282c3