Solved CA1063

Author: Randall Flagg

src/LogExpert.Core/Classes/Log/LogStreamReaderBase.cs

@@ -35,7 +35,7 @@ protected LogStreamReaderBase()
     /// <summary>
     /// Indicates whether or not the stream reader has already been disposed.
     /// </summary>
-    public bool IsDisposed { get; private set; }
+    public abstract bool IsDisposed { get; protected set; }
 
     #endregion
 
@@ -46,15 +46,8 @@ protected LogStreamReaderBase()
     /// </summary>
     public void Dispose()
     {
-        try
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-        finally
-        {
-            IsDisposed = true;
-        }
+        Dispose(true);
+        GC.SuppressFinalize(this);
     }
     /// <summary>
     /// Destroy and release the current stream reader.

src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderBase.cs

@@ -88,7 +88,8 @@ protected override void Dispose (bool disposing)
         {
             _stream.Dispose();
             _reader.Dispose();
-        }
+            IsDisposed = true;
+}
     }
 
     //TODO This is unsafe and should be refactored

src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderLegacy.cs

@@ -11,6 +11,8 @@ public class PositionAwareStreamReaderLegacy : PositionAwareStreamReaderBase
     private int _charBufferPos;
     private bool _crDetect;
 
+    public override bool IsDisposed { get; protected set; }
+
     #endregion
 
     #region cTor

src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderSystem.cs

@@ -17,6 +17,8 @@ public class PositionAwareStreamReaderSystem : PositionAwareStreamReaderBase
 
     private int _newLineSequenceLength;
 
+    public override bool IsDisposed { get; protected set; }
+
     #endregion
 
     #region cTor

src/LogExpert.Core/Classes/xml/XmlBlockSplitter.cs

@@ -24,6 +24,8 @@ public class XmlBlockSplitter : LogStreamReaderBase
     private string _stylesheet;
     private XslCompiledTransform _xslt;
 
+    public override bool IsDisposed { get; protected set; }
+
     #endregion
 
     #region cTor
@@ -136,6 +138,7 @@ protected override void Dispose(bool disposing)
         if (disposing)
         {
             _reader.Dispose();
+            IsDisposed = true;
         }
     }
 

src/LogExpert.Core/Classes/xml/XmlLogReader.cs

@@ -10,6 +10,7 @@ public class XmlLogReader : LogStreamReaderBase
     #region Fields
 
     private readonly ILogStreamReader reader;
+    public override bool IsDisposed { get; protected set; }
 
     #endregion
 
@@ -47,6 +48,7 @@ protected override void Dispose(bool disposing)
         if (disposing)
         {
             reader.Dispose();
+            IsDisposed = true;
         }
     }