chore: merge with main, consolidate log_event_components_test.exs

Author: msmithstubbs

lib/logflare_web/live/search_live/log_event_components.ex

@@ -21,7 +21,6 @@ defmodule LogflareWeb.SearchLive.LogEventComponents do
   attr :search_timezone, :string, required: true
   attr :tailing?, :boolean, required: true
   attr :querystring, :string, required: true
-  attr :lql_rules, :list, required: true
   attr :empty_event_message_placeholder, :string, default: @default_empty_event_message
   attr :search_op, Logflare.Logs.SearchOperation
 

test/logflare_web/live/search_live/log_event_components_test.exs

@@ -122,6 +122,70 @@ defmodule LogflareWeb.SearchLive.LogEventComponentsTest do
       # Assert logs list ul is NOT rendered when search_op_log_events is nil
       refute html =~ ~s|id="logs-list"|
     end
+
+    test "renders placeholder for log events with nil event_message", %{
+      source: source,
+      lql_rules: lql_rules
+    } do
+      log_event_without_message = %Logflare.LogEvent{
+        id: Ecto.UUID.generate(),
+        body: %{
+          "timestamp" => System.system_time(:microsecond),
+          "id" => Ecto.UUID.generate(),
+          "metadata" => %{"user_id" => 456}
+        },
+        source_id: source.id,
+        valid: true
+      }
+
+      search_op_log_events = %{rows: [log_event_without_message]}
+
+      html =
+        render_component(&LogEventComponents.results_list/1, %{
+          @default_attrs
+          | search_op: %{source: source, lql_rules: lql_rules, search_timezone: "Etc/UTC"},
+            search_op_log_events: search_op_log_events
+        })
+
+      assert html =~ "(empty event message)"
+      assert html =~ "tw-italic"
+      assert html =~ "tw-text-gray-500"
+    end
+
+    test "renders both normal and nil event_message log events", %{
+      source: source,
+      lql_rules: lql_rules
+    } do
+      normal_log_event =
+        build(:log_event,
+          message: "Normal log message",
+          metadata: %{user_id: 123},
+          source: source
+        )
+
+      log_event_without_message = %Logflare.LogEvent{
+        id: Ecto.UUID.generate(),
+        body: %{
+          "timestamp" => System.system_time(:microsecond),
+          "id" => Ecto.UUID.generate(),
+          "metadata" => %{"user_id" => 789}
+        },
+        source_id: source.id,
+        valid: true
+      }
+
+      search_op_log_events = %{rows: [normal_log_event, log_event_without_message]}
+
+      html =
+        render_component(&LogEventComponents.results_list/1, %{
+          @default_attrs
+          | search_op: %{source: source, lql_rules: lql_rules, search_timezone: "Etc/UTC"},
+            search_op_log_events: search_op_log_events
+        })
+
+      assert html =~ "Normal log message"
+      assert html =~ "(empty event message)"
+    end
   end
 
   describe "selected_fields/1" do