fix(compare): update drift detection logic to exclude added folders

- Modify comparison logic to classify only orphaned and drift folders as 'DRIFT'; added folders are now considered growth and result in a 'PASS'.
- Update related tests to reflect the new logic, ensuring accurate detection of drift and growth scenarios.

Author: AmiteK23

src/cli/handlers/compareHandler.ts

@@ -528,7 +528,8 @@ async function handleGitBaselineCompare(options: {
     };
 
     // Recalculate overall status
-    result.status = addedFolders > 0 || orphanedFolders > 0 || driftFolders > 0 ? 'DRIFT' : 'PASS';
+    // Only orphaned folders and drift folders qualify as drift; added folders are growth, not drift
+    result.status = orphanedFolders > 0 || driftFolders > 0 ? 'DRIFT' : 'PASS';
 
     displayMultiFileCompareResult(result, stats, quiet);
 

src/extractors/shared/propTypeNormalizer.ts

@@ -44,7 +44,8 @@ export function normalizePropType(typeText: string, isOptional: boolean): PropTy
             return trimmed.slice(1, -1);
           }
           return trimmed;
-        });
+        })
+        .sort(); // Sort literals for determinism
 
       return {
         type: 'literal-union',

src/utils/hash.ts

@@ -182,8 +182,9 @@ export function bundleHash(
  */
 export function stableStringify(obj: unknown): string {
   return JSON.stringify(obj, (k, v) => {
-    if (v && typeof v === 'object' && !Array.isArray(v)) {
-      // Sort object keys
+    // Explicitly check for null (typeof null === 'object' in JavaScript)
+    if (v !== null && typeof v === 'object' && !Array.isArray(v)) {
+      // Sort object keys recursively
       return Object.keys(v as Record<string, unknown>)
         .sort()
         .reduce((o, key) => {
@@ -192,7 +193,10 @@ export function stableStringify(obj: unknown): string {
         }, {} as Record<string, unknown>);
     }
     if (Array.isArray(v)) {
-      // Sort arrays for stability
+      // NOTE: Arrays are expected to be normalized and deterministically ordered
+      // by the extraction/normalization layer before reaching stableStringify.
+      // We only sort primitives here to prevent accidental ordering issues.
+      // Arrays of objects should be pre-sorted elsewhere (e.g., via sortObject).
       return [...v].sort();
     }
     return v;
@@ -201,12 +205,24 @@ export function stableStringify(obj: unknown): string {
 
 /**
  * Sort object keys for stable hashing
+ * Recursively sorts nested objects and arrays to ensure complete determinism
  */
 function sortObject<T extends Record<string, unknown>>(obj: T): T {
   const sorted = Object.keys(obj)
     .sort()
     .reduce((acc, key) => {
-      acc[key] = obj[key];
+      const value = obj[key];
+      // Recursively sort nested objects
+      if (value && typeof value === 'object' && !Array.isArray(value) && value !== null) {
+        acc[key] = sortObject(value as Record<string, unknown>);
+      } 
+      // Sort arrays for determinism (e.g., literals arrays in PropType objects)
+      else if (Array.isArray(value)) {
+        acc[key] = [...value].sort();
+      } 
+      else {
+        acc[key] = value;
+      }
       return acc;
     }, {} as Record<string, unknown>);
 

tests/e2e/cli.compare.test.ts

@@ -637,19 +637,15 @@ describe('CLI Compare Command Tests', () => {
         }], null, 2)
       );
 
-      // Compare - should detect ADDED FILE
-      try {
-        await execAsync(
-          `node dist/cli/stamp.js context compare ${join(outDir1, 'context_main.json')} ${join(outDir2, 'context_main.json')}`
-        );
-        expect.fail('Should have detected drift');
-      } catch (error: any) {
-        expect(error.code).toBe(1);
-        const output = error.stdout || '';
-        expect(output).toContain('DRIFT');
-        expect(output).toContain('ADDED FILE');
-        expect(output).toContain('src/new-folder/context.json');
-      }
+      // Compare - should detect ADDED FILE (but additions are growth, not drift, so should PASS)
+      const result = await execAsync(
+        `node dist/cli/stamp.js context compare ${join(outDir1, 'context_main.json')} ${join(outDir2, 'context_main.json')}`
+      );
+      const output = result.stdout || '';
+      // Additions are growth, not drift - should be PASS
+      expect(output).toContain('PASS');
+      expect(output).toContain('ADDED FILE');
+      expect(output).toContain('src/new-folder/context.json');
     }, 60000);
 
     it('should detect ORPHANED FILE when folder is removed', async () => {

tests/unit/commands/compare/core.test.ts

@@ -347,7 +347,8 @@ describe('diff', () => {
     const newIdx = index(newBundles);
 
     const result = diff(oldIdx, newIdx);
-    expect(result.status).toBe('DRIFT');
+    // Additions are growth, not drift - should be PASS
+    expect(result.status).toBe('PASS');
     expect(result.added).toContain('src/button.tsx');
     expect(result.removed).toHaveLength(0);
   });

tests/unit/commands/compare/multiFile.test.ts

@@ -151,7 +151,8 @@ describe('multiFileCompare', () => {
       newIndexFile: '/new/context_main.json',
     });
 
-    expect(result.status).toBe('DRIFT');
+    // Additions are growth, not drift - should be PASS
+    expect(result.status).toBe('PASS');
     expect(result.summary.addedFolders).toBe(1);
   });
 

tests/unit/commands/compare/singleFile.test.ts

@@ -129,7 +129,8 @@ describe('compareCommand', () => {
       newFile: 'new.json',
     });
 
-    expect(result.status).toBe('DRIFT');
+    // Additions are growth, not drift - should be PASS
+    expect(result.status).toBe('PASS');
     expect(result.added).toContain('src/button.tsx'); // Note: lowercased
   });