Merge remote-tracking branch 'origin/dev' into issue/OSOE-1185

Author: sarahelsaig

Directory.Build.props

@@ -29,9 +29,9 @@
   </PropertyGroup>-->
 
   <!-- Uncomment this to run .NET static code analyzers during rebuilds. -->
-  <!--<PropertyGroup>
+  <PropertyGroup>
     <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
-  </PropertyGroup>-->
+  </PropertyGroup>
 
   <Import Project="tools/Lombiq.Analyzers/Lombiq.Analyzers.OrchardCore/Build.props" />
 

NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj

@@ -33,7 +33,7 @@
     <PackageReference Include="Lombiq.EmailClient" Version="1.0.0-alpha.8.osoe-1064" />
     <PackageReference Include="Lombiq.EmailClient.Samples" Version="1.0.0-alpha.8.osoe-1064" />
     <PackageReference Include="Lombiq.HelpfulExtensions" Version="11.0.1-alpha.1.olys-35" />
-    <PackageReference Include="Lombiq.HelpfulLibraries" Version="12.3.1-alpha.2.osoe-1171" />
+    <PackageReference Include="Lombiq.HelpfulLibraries" Version="12.4.0" />
     <PackageReference Include="Lombiq.Hosting.Azure.ApplicationInsights" Version="10.0.1-alpha.0.osoe-935" />
     <PackageReference Include="Lombiq.Hosting.BuildVersionDisplay" Version="7.0.1-alpha.2.nest-561" />
     <PackageReference Include="Lombiq.Hosting.MediaTheme" Version="8.0.1-alpha.7.olys-29" />

NuGetTest/src/Modules/Lombiq.OSOCE.NuGet.TestModule/Lombiq.OSOCE.NuGet.TestModule.csproj

@@ -16,7 +16,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Lombiq.HelpfulLibraries" Version="12.3.1-alpha.2.osoe-1171" />
+    <PackageReference Include="Lombiq.HelpfulLibraries" Version="12.4.0" />
     <PackageReference Include="OrchardCore.Module.Targets" Version="2.1.0" />
     <PackageReference Include="OrchardCore.ContentManagement" Version="2.1.0" />
     <PackageReference Include="OrchardCore.ContentTypes.Abstractions" Version="2.1.0" />

NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj

@@ -21,7 +21,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Lombiq.HelpfulLibraries.OrchardCore" Version="12.3.1-alpha.2.osoe-1171" />
+    <PackageReference Include="Lombiq.HelpfulLibraries.OrchardCore" Version="12.4.0" />
     <PackageReference Include="Lombiq.BaseTheme.Tests.UI" Version="10.0.1" />
     <PackageReference Include="Lombiq.ChartJs.Tests.UI" Version="9.0.1-alpha.0.osoe-935" />
     <PackageReference Include="Lombiq.ContentEditors.Tests.UI" Version="6.0.0-alpha.4.osoe-1171" />

NuGetTest/test/Lombiq.OSOCE.NuGet.Tests/Lombiq.OSOCE.NuGet.Tests.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Lombiq.HelpfulLibraries" Version="12.3.1-alpha.2.osoe-1171" />
+    <PackageReference Include="Lombiq.HelpfulLibraries" Version="12.4.0" />
     <PackageReference Include="Lombiq.Tests" Version="5.0.0" />
     <PackageReference Include="Lombiq.EInvoiceValidator" Version="1.0.0" />
     <PackageReference Include="Lombiq.EInvoiceValidator.Sample" Version="1.0.0" />

test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorPrivacyTests.cs

@@ -41,10 +41,10 @@ await ExecuteTestAfterSetupAsync(
             configuration => configuration.HtmlValidationConfiguration.AssertHtmlValidationResultAsync =
                 validationResult =>
                 {
-                    // Error filtering due to https://github.com/OrchardCMS/OrchardCore/issues/15222,
-                    // can be removed once it is resolved.
+                    // Error filtering due to https://github.com/OrchardCMS/OrchardCore/issues/15222 and
+                    // https://github.com/OrchardCMS/OrchardCore/issues/18510. Can be removed once they are resolved.
                     var errors = validationResult.GetParsedErrors()
-                        .Where(error => error.RuleId is not "prefer-native-element");
+                        .Where(error => error.RuleId is not "prefer-native-element" and not "aria-label-misuse");
                     errors.ShouldBeEmpty(HtmlValidationResultExtensions.GetParsedErrorMessageString(errors));
                     return Task.CompletedTask;
                 });