Skip to content

Commit 634c27c

Browse files
committed
Re-enable Windows NuGet test.
1 parent 29e3ec2 commit 634c27c

File tree

1 file changed

+28
-28
lines changed

1 file changed

+28
-28
lines changed

.github/workflows/build-and-test-windows.yml

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -78,32 +78,32 @@ jobs:
7878
verify-dotnet-consolidation: false
7979
node-version: none
8080

81-
# build-and-test-nuget-test:
82-
# if: github.ref_name == github.event.repository.default_branch ||
83-
# github.event_name == 'workflow_dispatch' ||
84-
# github.event.label.name == 'run-windows-build' ||
85-
# (github.event.review.state == 'APPROVED' && contains(github.event.pull_request.labels.*.name, 'requires-windows-build'))
86-
# name: Build and Test Windows - NuGetTest solution
87-
# uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-925
88-
# with:
89-
# parent-job-name: nuget-solution
90-
# machine-types: '["windows-2025"]'
91-
# build-directory: NuGetTest
92-
# timeout-minutes: 30
93-
# # This way, we can see Node.js build issues in the build log.
94-
# build-verbosity: minimal
95-
# dotnet-test-process-timeout: 900000
96-
# # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not
97-
# # supported by GHA.
98-
# # The currently used Elasticsearch setup action (https://github.com/elastic/elastic-github-actions/tree/master/elasticsearch)
99-
# # can only be used on Linux.
100-
# # Without quotes, somehow the value won't be passed properly and the test execution will hang, despite seemingly
101-
# # every value being the same as with quotes.
102-
# # yamllint disable-line rule:quoted-strings
103-
# test-filter: 'FullyQualifiedName!~SecurityScanningTests&FullyQualifiedName!~ElasticsearchTests'
104-
# # It's enough to check consolidation only in the Linux workflow.
105-
# verify-dotnet-consolidation: false
106-
# node-version: none
81+
build-and-test-nuget-test:
82+
if: github.ref_name == github.event.repository.default_branch ||
83+
github.event_name == 'workflow_dispatch' ||
84+
github.event.label.name == 'run-windows-build' ||
85+
(github.event.review.state == 'APPROVED' && contains(github.event.pull_request.labels.*.name, 'requires-windows-build'))
86+
name: Build and Test Windows - NuGetTest solution
87+
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-925
88+
with:
89+
parent-job-name: nuget-solution
90+
machine-types: '["windows-2025"]'
91+
build-directory: NuGetTest
92+
timeout-minutes: 30
93+
# This way, we can see Node.js build issues in the build log.
94+
build-verbosity: minimal
95+
dotnet-test-process-timeout: 900000
96+
# Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not
97+
# supported by GHA.
98+
# The currently used Elasticsearch setup action (https://github.com/elastic/elastic-github-actions/tree/master/elasticsearch)
99+
# can only be used on Linux.
100+
# Without quotes, somehow the value won't be passed properly and the test execution will hang, despite seemingly
101+
# every value being the same as with quotes.
102+
# yamllint disable-line rule:quoted-strings
103+
test-filter: 'FullyQualifiedName!~SecurityScanningTests&FullyQualifiedName!~ElasticsearchTests'
104+
# It's enough to check consolidation only in the Linux workflow.
105+
verify-dotnet-consolidation: false
106+
node-version: none
107107

108108
asset-lint:
109109
if: github.ref_name == github.event.repository.default_branch ||
@@ -126,7 +126,7 @@ jobs:
126126

127127
post-pull-request-checks-automation:
128128
name: Post Pull Request Checks Automation
129-
needs: [build-and-test-larger-runners, powershell-static-code-analysis]
129+
needs: [build-and-test-larger-runners, build-and-test-nuget-test, powershell-static-code-analysis]
130130
if: github.event.pull_request != ''
131131
uses: Lombiq/GitHub-Actions/.github/workflows/post-pull-request-checks-automation.yml@dev
132132
secrets:
@@ -139,7 +139,7 @@ jobs:
139139
name: Remove Windows Build Warning Label
140140
runs-on: ubuntu-24.04
141141
timeout-minutes: 2
142-
needs: [build-and-test-larger-runners, asset-lint, powershell-static-code-analysis]
142+
needs: [build-and-test-larger-runners, build-and-test-nuget-test, asset-lint, powershell-static-code-analysis]
143143
steps:
144144
- name: Remove Windows Build Warning Label
145145
uses: Lombiq/GitHub-Actions/.github/actions/add-remove-label@dev

0 commit comments

Comments
 (0)