Revert "fix: quick fix ts"

This reverts commit 36a4d6f.

Author: MatthewPattell

src/deep-compare.ts

@@ -18,10 +18,7 @@ const deepCompare = (obj1: unknown, obj2: unknown): boolean => {
   }
 
   for (const key of keys1) {
-    if (
-      !keys2.includes(key) ||
-      !deepCompare((obj1 as Record<string, unknown>)[key], (obj2 as Record<string, unknown>)[key])
-    ) {
+    if (!keys2.includes(key) || !deepCompare(obj1[key], obj2[key])) {
       return false;
     }
   }

src/logger.ts

@@ -12,8 +12,6 @@ export interface ILoggerOpts {
   manager: Manager;
 }
 
-type LogMethod = 'log' | 'error' | 'warn' | 'info';
-
 export interface ILoggerLogOpts {
   level: ILoggerOpts['level'];
   err?: Error;
@@ -41,7 +39,7 @@ class Logger {
       return;
     }
 
-    let type: LogMethod = 'log';
+    let type = 'log';
 
     switch (level) {
       case 1:

src/make-exported.ts

@@ -13,7 +13,6 @@ const makeExported = <T extends object>(
   },
   shouldExtend = true,
 ): void => {
-  // @ts-ignore
   store[exportedPropName] = { ...(shouldExtend ? store?.[exportedPropName] ?? {} : {}), ...props };
 };
 
@@ -22,22 +21,19 @@ const makeExported = <T extends object>(
  * @see IPersistOptions
  */
 const isPropExcludedInPersist = (store: TAnyStore): boolean => {
-  // @ts-ignore
   return store?.['libStorageOptions']?.isNotExported || false;
 };
 
 /**
  * Check if store prop is observable exported
  */
 const isPropObservableExported = (store: TAnyStore, prop: string): boolean =>
-  // @ts-ignore
   store?.[exportedPropName]?.[prop] === 'observable';
 
 /**
  * Check if store prop is simple exported
  */
 const isPropSimpleExported = (store: TAnyStore, prop: string): boolean =>
-  // @ts-ignore
   store?.[exportedPropName]?.[prop] === 'simple';
 
 /**
@@ -48,7 +44,6 @@ const isPropExcludedFromExport = (
   prop: string,
   withNotExported = false,
 ): boolean =>
-  // @ts-ignore
   store?.[exportedPropName]?.[prop] === 'excluded' ||
   (!withNotExported && isPropExcludedInPersist(store));
 

src/manager.ts

@@ -201,7 +201,6 @@ class Manager {
       return store.libStoreId;
     }
 
-    // @ts-ignore
     let storeId = (store['id'] as string) || (store['name'] as string) || store.constructor.name;
 
     if (store.isGlobal) {
@@ -386,13 +385,10 @@ class Manager {
         });
 
         if (isParent) {
-          // @ts-ignore
           res.parentStores[key] = storeInstance;
         } else if (storeInstance.isGlobal) {
-          // @ts-ignore
           res.globalStores[key] = storeInstance;
         } else {
-          // @ts-ignore
           res.relativeStores[key] = storeInstance;
         }
 
@@ -629,7 +625,6 @@ class Manager {
       : this.stores;
 
     for (const [storeId, store] of stores.entries()) {
-      // @ts-ignore
       result[storeId] = this.getStoreState(store, isIncludeExported);
     }
 
@@ -670,7 +665,7 @@ class Manager {
           ? { [prop]: value }
           : {}),
         ...(isPropObservableExported(store, prop)
-          ? { [prop]: Manager.getObservableProps((store as any)[prop] as TAnyStore) }
+          ? { [prop]: Manager.getObservableProps(store[prop] as TAnyStore) }
           : {}),
       }),
       {},

src/plugins/dev-extension/index.ts

@@ -2,7 +2,6 @@ import type Manager from '../../manager';
 import StateListener from './state-listener';
 
 function connectDevExtension(storeManager: Manager): void {
-  // @ts-ignore
   window['__MOBX_STORE_MANAGER__'] = new StateListener(storeManager).subscribe();
 }
 

src/plugins/dev-extension/state-listener.ts

@@ -92,7 +92,6 @@ class StateListener {
         return;
       }
 
-      // @ts-ignore
       this.manager?.['__devOnChange']?.({
         event: _.cloneDeep(event),
         storesState: this.getStoresState(),

src/plugins/vite/index.ts

@@ -19,11 +19,9 @@ function ViteReactMobxManager(): Plugin[] {
         idGeneratorPlugin = IdGenerator({ root, isProd: isProduction() });
       },
       transform(...args) {
-        // @ts-ignore
         return idGeneratorPlugin.transform?.['call'](this, ...args) as TransformResult | undefined;
       },
       buildEnd(...args) {
-        // @ts-ignore
         idGeneratorPlugin.buildEnd?.['call'](this, ...args);
       },
     },

src/suspense-query.ts

@@ -85,7 +85,6 @@ class SuspenseQuery {
    */
   protected jsonToError(e: Error, values: Record<string, any>): Error {
     this.params.errorFields.forEach((name) => {
-      // @ts-ignore
       e[name] = values?.[name];
     });
 
@@ -96,7 +95,6 @@ class SuspenseQuery {
    * Throw suspense error
    */
   protected throwError(): void {
-    // @ts-ignore
     const value = this.store[this.params.fieldName];
 
     // pass error to error boundary
@@ -114,7 +112,6 @@ class SuspenseQuery {
    *  - skip run suspense if already completed
    */
   protected isComplete(hash: unknown): boolean {
-    // @ts-ignore
     const value = this.store[this.params.fieldName];
 
     // pass error to error boundary
@@ -140,9 +137,7 @@ class SuspenseQuery {
       return;
     }
 
-    // @ts-ignore
     if (this.store[fieldName]?.hash !== hash) {
-      // @ts-ignore
       this.store[fieldName] = { hash, done: false };
       this.promise = undefined;
     }
@@ -152,13 +147,11 @@ class SuspenseQuery {
 
       this.promise.then(
         () => {
-          // @ts-ignore
           this.store[fieldName] = { hash, done: true };
         },
         (e) => {
           this.errorJson(e);
 
-          // @ts-ignore
           this.store[fieldName] = { error: e };
         },
       );

src/with-stores.tsx

@@ -15,8 +15,7 @@ const withStores = <T extends Record<string, any>, TS extends TMapStores>(
   { customContextId }: IWithStoreOptions = {},
 ): FC<Omit<T, keyof TS>> => {
   const ObservableComponent = observer(Component) as FC;
-  const manualContextId =
-    customContextId || (Component as FC<T> & { libStoreContextId?: string })['libStoreContextId'];
+  const manualContextId = customContextId || (Component['libStoreContextId'] as string);
   const componentName = Component.displayName || Component.name;
 
   const Element: FC<Omit<T, keyof TS>> = (props) => {

tsconfig.json

@@ -29,6 +29,7 @@
     "strictNullChecks": true,
     "strict": false,
     "pretty": true,
+    "suppressImplicitAnyIndexErrors": true,
     "useDefineForClassFields": true,
     "baseUrl": ".",
     "paths": {