Updates from PR review

Author: ps2

Loop/Managers/DeviceDataManager.swift

@@ -1074,8 +1074,6 @@ extension DeviceDataManager: PumpManagerDelegate {
     }
 
     func pumpManagerPumpWasReplaced(_ pumpManager: PumpManager) {
-        // PumpManagers should report a continuous dosing history, across pump changes
-        //doseStore.resetPumpData(completion: nil)
     }
 
     func pumpManagerWillDeactivate(_ pumpManager: PumpManager) {

Loop/Managers/Store Protocols/DoseStoreProtocol.swift

@@ -42,8 +42,6 @@ protocol DoseStoreProtocol: AnyObject {
     var pumpEventQueryAfterDate: Date { get }
 
     // MARK: dose management
-    func resetPumpData(completion: ((_ error: DoseStore.DoseStoreError?) -> Void)?)
-    
     func addPumpEvents(_ events: [NewPumpEvent], lastReconciliation: Date?, completion: @escaping (_ error: DoseStore.DoseStoreError?) -> Void)
 
     func addReservoirValue(_ unitVolume: Double, at date: Date, completion: @escaping (_ value: ReservoirValue?, _ previousValue: ReservoirValue?, _ areStoredValuesContinuous: Bool, _ error: DoseStore.DoseStoreError?) -> Void)

LoopTests/Mock Stores/MockDoseStore.swift

@@ -71,10 +71,6 @@ class MockDoseStore: DoseStoreProtocol {
         completion(nil)
     }
 
-    func resetPumpData(completion: ((DoseStore.DoseStoreError?) -> Void)?) {
-        completion?(.configurationError)
-    }
-    
     func getInsulinOnBoardValues(start: Date, end: Date?, basalDosingEnd: Date?, completion: @escaping (DoseStoreResult<[InsulinValue]>) -> Void) {
         completion(.failure(.configurationError))
     }