Skip to content

Commit c96337f

Browse files
committed
wip: update from reviewer comments
1 parent 97baafb commit c96337f

File tree

3 files changed

+34
-11
lines changed

3 files changed

+34
-11
lines changed

docs/browser/bb-errors.md

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,17 @@ If you are new builder who gets an error at `Add Identifiers`, please [ask a men
332332
333333
## Action: `Create Certificates` Errors
334334
335+
The modern version of Browser Build creates your certificates automatically when you run the build action.
336+
337+
The first time you run the build action, there might be a certificate error if you did not configure your secrets or Identifiers correctly.
338+
339+
Subsequent times:
340+
341+
* You must have your *Apple* Developer license up to date with all agreements signed
342+
* After a year, you must have the [`ENABLE_NUKE_CERTS` variable](prepare-fork.md#add-variable){: target="_blank" } set to true for automatic renewal - make sure to set that up now
343+
344+
and
345+
335346
> Reminder - If it is not obvious to you what your error is, please [ask a mentor for help](#where-to-get-help-with-browser-build)
336347
337348
> * you might get to the answer sooner
@@ -361,7 +372,7 @@ If that phrase is found, then:
361372
* You probably do not have the correct `TEAMID` entered in your `Secrets`
362373
* The rest of these instructions assume:
363374
* You have already created a *Loop* App in the *App Store* with that incorrect `TEAMID`
364-
* This is true if you completed the steps after running Action: `Add Identifiers` and before Action: `Create Certificates`
375+
* This is true if you completed the steps after running Action: `Add Identifiers` and before Action: `Create Certificates` or `Build Loop`
365376
366377
Click on this link to [Delete Identifiers](#delete-identifiers).
367378
@@ -412,7 +423,9 @@ Follow the [Configure to Use Browser: Create Loop App in App Store Connect](prep
412423
413424
#### Create Certificates
414425
415-
You should be able to continue with the [Configure to Use Browser Steps to `Create Certificates`](certs.md#create-certificates) and then proceed from there with `Build Loop` and keep going.
426+
You can go straight to [`Build Loop`](build-yml.md#build-the-loop-app){: target="_blank" } which will `Create Certificates` for you. However, you may be more comfortable making sure you got your mistakes fixed. You can run [`Create Certifcates`](certs.md#create-certificates){: target="_blank" } as a stand-alone process. It should only take a few minutes.
427+
428+
After that succeeds, proceed to [`Build Loop`](build-yml.md#build-the-loop-app){: target="_blank" } and keep going.
416429
417430
### Error: Error cloning certificates
418431
@@ -771,6 +784,13 @@ You will get an email informing you the certificate was revoked.
771784
772785
Run the Build action and a new Distribution Certificate will be created along with the profiles and build credentials needed.
773786
787+
!!! question "But my Build Action Failed Again"
788+
- [x] Make sure you deleted all the Distribution Certificates as directed above.
789+
790+
- [x] Make sure you have the [`ENABLE_NUKE_CERTS` variable](prepare-fork.md#add-variable){: target="_blank" } set to true
791+
792+
- [ ] Then follow the link to delete your [Match Secrets repository](#delete-match-secrets) and run the [`Build Loop`](build-yml.md#build-the-loop-app){: target="_blank" } again.
793+
774794
* This is true for Loop, LoopCaregiver, LoopFollow and Trio if you have the ENABLE_NUKE_CERTS variable set to true
775795
776796
!!! question "But what about *TestFlight* builds?"
@@ -832,7 +852,7 @@ Make sure you only delete `Match-Secrets`. Do NOT delete the repository of the a
832852
833853
When building Loop, LoopCaregiver, LoopFollow or Trio:
834854
835-
* If you just revoked a [Distrbution Certificate](#revoke-distribution-certificate) - please do not delete your `Match-Secrets`
855+
* If you just revoked a [Distrbution Certificate](#revoke-distribution-certificate) - try building first before you delete your `Match-Secrets`
836856
* Make sure you have `ENABLE_NUKE_CERTS` set to true
837857
* The next time you try to build, the information in Match-Secrets is used to remove invalid profiles
838858
* A new Distribution Certificate and new profiles will be generated and your Match-Secrets will be updated

docs/browser/bb-overview.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111

1212
**Choose Browser Build if:**
1313

14-
* You don't have a Mac or prefer not to use one
15-
* You want automatic monthly builds (after initial setup)
16-
* You're comfortable following step-by-step instructions with multiple accounts (Apple, GitHub)
17-
* You can dedicate 2-4 hours for first-time setup (spread over several days)
14+
- [x] You don't have a Mac or prefer not to use one
15+
- [x] You want automatic monthly builds (after initial setup)
16+
- [x] You're comfortable following step-by-step instructions with multiple accounts (Apple, GitHub)
17+
- [x] You can dedicate 2-4 hours for first-time setup (spread over several days)
1818

1919
**Choose Mac Build if:**
2020

21-
* You already have an up-to-date Mac and are comfortable with Xcode
22-
* You prefer building locally without cloud services
23-
* See [Build with Mac](../build/overview.md){: target="_blank" } for Mac requirements
21+
- [x] You already have an up-to-date Mac and are comfortable with Xcode
22+
- [x] You prefer building locally without cloud services
23+
- [x] See [Build with Mac](../build/overview.md){: target="_blank" } for Mac requirements
2424

2525
## Requirements
2626

mkdocs.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,17 @@ markdown_extensions:
5252
- abbr
5353
- admonition
5454
- attr_list
55+
- def_list
5556
- pymdownx.arithmatex:
56-
generic: true
57+
generic: true
5758
- pymdownx.details
5859
- pymdownx.emoji:
5960
emoji_index: !!python/name:material.extensions.emoji.twemoji
6061
emoji_generator: !!python/name:material.extensions.emoji.to_svg
6162
- pymdownx.highlight
6263
- pymdownx.mark
64+
- pymdownx.tasklist:
65+
custom_checkbox: true
6366
- pymdownx.tilde
6467
- pymdownx.inlinehilite
6568
- pymdownx.keys

0 commit comments

Comments
 (0)