From c8d1a6fca0c34a6ba6f2f73e1a6ec6d552ba1e9d Mon Sep 17 00:00:00 2001 From: Diego Valcarce Date: Tue, 29 Jul 2025 12:47:39 +0200 Subject: [PATCH] Prefer dependencies over selects (fix #13) As stated in the Zephyr Kconfig recommendations [1], it is preferred to use `depends on`: > Avoid selecting symbols with prompts or dependencies. Prefer depends on. This can be related to https://github.com/zephyrproject-rtos/zephyr/issues/52575 This commit is backward compatible as long as the REBOOT symbol is selected, which can be done mannually or through a subsystem (like LBM was doing). [1]: https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-recommendations --- subsys/lorawan_lbm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/subsys/lorawan_lbm/Kconfig b/subsys/lorawan_lbm/Kconfig index f115415..965880f 100644 --- a/subsys/lorawan_lbm/Kconfig +++ b/subsys/lorawan_lbm/Kconfig @@ -8,9 +8,8 @@ menuconfig LORA_BASICS_MODEM depends on LORA_BASICS_MODEM_DRIVERS select EXPERIMENTAL select LORA_BASICS_MODEM_DRIVERS_RAL_RALF - select REBOOT # depends on REQUIRES_FULL_LIBC - depends on TEST_RANDOM_GENERATOR || ENTROPY_HAS_DRIVER + depends on ( TEST_RANDOM_GENERATOR || ENTROPY_HAS_DRIVER ) && REBOOT select ZEPHYR_LORA_BASICS_MODEM_MODULE depends on !LORAWAN help