Skip to content

Commit 21e8035

Browse files
committed
Remove FPort greater than 224 checks.
#416
1 parent 0b7ebff commit 21e8035

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

src/mac/LoRaMac.c

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -593,15 +593,6 @@ LoRaMacStatus_t SetTxContinuousWave1( uint16_t timeout, uint32_t frequency, uint
593593
*/
594594
static void ResetMacParameters( void );
595595

596-
/*!
597-
* \brief Checks if the fPort value is allowed
598-
*
599-
* \param [IN] fPort The fPort
600-
*
601-
* \retval [false: fPort not allowed, true: fPort allowed]
602-
*/
603-
static bool IsFPortAllowed( uint8_t fPort );
604-
605596
/*!
606597
* \brief Opens up a continuous RX 2 window. This is used for
607598
* class c devices.
@@ -1050,13 +1041,6 @@ static void ProcessRadioRxDone( void )
10501041
return;
10511042
}
10521043

1053-
if( IsFPortAllowed( macMsgData.FPort ) == false )
1054-
{
1055-
MacCtx.McpsIndication.Status = LORAMAC_EVENT_INFO_STATUS_ERROR;
1056-
PrepareRxDoneAbort( );
1057-
return;
1058-
}
1059-
10601044
//Check if it is a multicast message
10611045
multicast = 0;
10621046
downLinkCounter = 0;
@@ -2418,15 +2402,6 @@ static void ResetMacParameters( void )
24182402
MacCtx.NvmCtx->LastTxChannel = MacCtx.NvmCtx->Channel;
24192403
}
24202404

2421-
static bool IsFPortAllowed( uint8_t fPort )
2422-
{
2423-
if( fPort > 224 )
2424-
{
2425-
return false;
2426-
}
2427-
return true;
2428-
}
2429-
24302405
static void OpenContinuousRx2Window( void )
24312406
{
24322407
OnRxWindow2TimerEvent( );
@@ -4313,12 +4288,6 @@ LoRaMacStatus_t LoRaMacMcpsRequest( McpsReq_t* mcpsRequest )
43134288
break;
43144289
}
43154290

4316-
// Filter fPorts
4317-
if( IsFPortAllowed( fPort ) == false )
4318-
{
4319-
return LORAMAC_STATUS_PARAMETER_INVALID;
4320-
}
4321-
43224291
// Get the minimum possible datarate
43234292
getPhy.Attribute = PHY_MIN_TX_DR;
43244293
getPhy.UplinkDwellTime = MacCtx.NvmCtx->MacParams.UplinkDwellTime;

0 commit comments

Comments
 (0)