Bug fix in function OnRadioRxDone. At this location, we must decrease the commandsSize by 1, since it was increased previously by the size of the fport.

Daniel Jäckle · Daniel Jäckle · commit 34f68ba3bae5 · 2016-06-22T08:30:47.000+02:00
diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
@@ -1249,8 +1249,8 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t
                         {
                             if( fCtrl.Bits.FOptsLen > 0 )
                             {
-                                // Decode Options field MAC commands
-                                ProcessMacCommands( payload, 8, appPayloadStartIndex, snr );
+                                // Decode Options field MAC commands. Omit the fPort.
+                                ProcessMacCommands( payload, 8, appPayloadStartIndex - 1, snr );
                             }
 
                             LoRaMacPayloadDecrypt( payload + appPayloadStartIndex,

Original file line number	Diff line number	Diff line change
`@@ -1249,8 +1249,8 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t`
`1249`	`1249`	`{`
`1250`	`1250`	`if( fCtrl.Bits.FOptsLen > 0 )`
`1251`	`1251`	`{`
`1252`		`- // Decode Options field MAC commands`
`1253`		`- ProcessMacCommands( payload, 8, appPayloadStartIndex, snr );`
	`1252`	`+ // Decode Options field MAC commands. Omit the fPort.`
	`1253`	`+ ProcessMacCommands( payload, 8, appPayloadStartIndex - 1, snr );`
`1254`	`1254`	`}`
`1255`	`1255`
`1256`	`1256`	`LoRaMacPayloadDecrypt( payload + appPayloadStartIndex,`