Issue #1065 - Fixed LoRaMacMcChannelSetupRxParams to return LORAMAC_STATUS_PARAMETER_INVALID if parameters validation did not succeed

mluis1 · mluis1 · commit 3e31fba825ae · 2021-12-07T09:03:47.000+01:00
diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
@@ -4960,6 +4960,10 @@ LoRaMacStatus_t LoRaMacMcChannelSetupRxParams( AddressIdentifier_t groupID, McRx
         // Apply parameters
         Nvm.MacGroup2.MulticastChannelList[groupID].ChannelParams.RxParams = *rxParams;
     }
+    else
+    {
+        return LORAMAC_STATUS_PARAMETER_INVALID;
+    }
 
     if( rxParams->Class == CLASS_B )
     {

Original file line number	Diff line number	Diff line change
`@@ -4960,6 +4960,10 @@ LoRaMacStatus_t LoRaMacMcChannelSetupRxParams( AddressIdentifier_t groupID, McRx`
`4960`	`4960`	`// Apply parameters`
`4961`	`4961`	`Nvm.MacGroup2.MulticastChannelList[groupID].ChannelParams.RxParams = *rxParams;`
`4962`	`4962`	`}`
	`4963`	`+ else`
	`4964`	`+ {`
	`4965`	`+ return LORAMAC_STATUS_PARAMETER_INVALID;`
	`4966`	`+ }`
`4963`	`4967`
`4964`	`4968`	`if( rxParams->Class == CLASS_B )`
`4965`	`4969`	`{`