Fixed PR #1569 for loop j variable wasn't being incremented.

mluis1 · mluis1 · commit 6384af8f4c4a · 2023-09-25T13:09:41.000+02:00
diff --git a/src/boards/mcu/utilities.c b/src/boards/mcu/utilities.c
@@ -107,7 +107,7 @@ uint32_t Crc32( uint8_t *buffer, uint16_t length )
     for( uint16_t i = 0; i < length; ++i )
     {
         crc ^= ( uint32_t )buffer[i];
-        for( uint16_t j = 0; j < 8; i++ )
+        for( uint16_t j = 0; j < 8; j++ )
         {
             crc = ( crc >> 1 ) ^ ( reversedPolynom & ~( ( crc & 0x01 ) - 1 ) );
         }
@@ -137,7 +137,7 @@ uint32_t Crc32Update( uint32_t crcInit, uint8_t *buffer, uint16_t length )
     for( uint16_t i = 0; i < length; ++i )
     {
         crc ^= ( uint32_t )buffer[i];
-        for( uint16_t j = 0; j < 8; i++ )
+        for( uint16_t j = 0; j < 8; j++ )
         {
             crc = ( crc >> 1 ) ^ ( reversedPolynom & ~( ( crc & 0x01 ) - 1 ) );
         }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ uint32_t Crc32( uint8_t *buffer, uint16_t length )`
`107`	`107`	`for( uint16_t i = 0; i < length; ++i )`
`108`	`108`	`{`
`109`	`109`	`crc ^= ( uint32_t )buffer[i];`
`110`		`- for( uint16_t j = 0; j < 8; i++ )`
	`110`	`+ for( uint16_t j = 0; j < 8; j++ )`
`111`	`111`	`{`
`112`	`112`	`crc = ( crc >> 1 ) ^ ( reversedPolynom & ~( ( crc & 0x01 ) - 1 ) );`
`113`	`113`	`}`
`@@ -137,7 +137,7 @@ uint32_t Crc32Update( uint32_t crcInit, uint8_t *buffer, uint16_t length )`
`137`	`137`	`for( uint16_t i = 0; i < length; ++i )`
`138`	`138`	`{`
`139`	`139`	`crc ^= ( uint32_t )buffer[i];`
`140`		`- for( uint16_t j = 0; j < 8; i++ )`
	`140`	`+ for( uint16_t j = 0; j < 8; j++ )`
`141`	`141`	`{`
`142`	`142`	`crc = ( crc >> 1 ) ^ ( reversedPolynom & ~( ( crc & 0x01 ) - 1 ) );`
`143`	`143`	`}`