Added the possibility to Enable/Disable the LoRaWAN certification FPort (224)

mluis1 · mluis1 · commit b9390d6ce70d · 2020-11-13T13:26:47.000+01:00
diff --git a/src/apps/LoRaMac/common/LmHandler/packages/LmhpCompliance.c b/src/apps/LoRaMac/common/LmHandler/packages/LmhpCompliance.c
@@ -22,6 +22,7 @@
 #include <stdint.h>
 #include <stdbool.h>
 #include "board.h"
+#include "NvmCtxMgmt.h"
 #include "LoRaMacTest.h"
 #include "LmHandler.h"
 #include "LmhpCompliance.h"
@@ -261,6 +262,7 @@ static void LmhpComplianceProcess( void )
     if( ComplianceTestState.IsResetCmdPending == true )
     {
         ComplianceTestState.IsResetCmdPending = false;
+
         // Call platform MCU reset API
         BoardResetMcu( );
     }
@@ -269,17 +271,13 @@ static void LmhpComplianceProcess( void )
 static void LmhpComplianceOnMcpsIndication( McpsIndication_t* mcpsIndication )
 {
     uint8_t cmdIndex        = 0;
+    MibRequestConfirm_t mibReq;
 
     if( ComplianceTestState.Initialized == false )
     {
         return;
     }
 
-    if( ComplianceParams->IsDutFPort224On == false )
-    {
-        return;
-    }
-
     // Increment the compliance certification protocol downlink counter
     // Not counting downlinks on FPort 0
     if( ( mcpsIndication->Port > 0 ) || ( mcpsIndication->AckReceived == true ) )
@@ -447,8 +445,10 @@ static void LmhpComplianceOnMcpsIndication( McpsIndication_t* mcpsIndication )
         }
         case COMPLIANCE_DUT_FPORT_224_DISABLE_REQ:
         {
-            // TODO: Handle FPort 224 control NVM update
-            ComplianceParams->IsDutFPort224On = false;
+            mibReq.Type = MIB_IS_CERT_FPORT_ON;
+            mibReq.Param.IsCertPortOn = false;
+            LoRaMacMibSetRequestConfirm( &mibReq );
+
             ComplianceTestState.IsResetCmdPending = true;
             break;
         }
@@ -521,11 +521,6 @@ static void LmhpComplianceOnMlmeIndication( MlmeIndication_t* mlmeIndication )
         return;
     }
 
-    if( ComplianceParams->IsDutFPort224On == false )
-    {
-        return;
-    }
-
     switch( mlmeIndication->MlmeIndication )
     {
         case MLME_BEACON_LOST:
diff --git a/src/apps/LoRaMac/common/LmHandler/packages/LmhpCompliance.h b/src/apps/LoRaMac/common/LmHandler/packages/LmhpCompliance.h
@@ -37,10 +37,6 @@
  */
 typedef struct LmhpComplianceParams_s
 {
-    /*!
-     * Indicates if the DUT FPort 224 is enabled.
-     */
-    bool IsDutFPort224On;
     /*!
      * Current firmware version
      */
diff --git a/src/apps/LoRaMac/fuota-test-01/B-L072Z-LRWAN1/main.c b/src/apps/LoRaMac/fuota-test-01/B-L072Z-LRWAN1/main.c
@@ -230,7 +230,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/NAMote72/main.c b/src/apps/LoRaMac/fuota-test-01/NAMote72/main.c
@@ -223,7 +223,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/NucleoL073/main.c b/src/apps/LoRaMac/fuota-test-01/NucleoL073/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/NucleoL152/main.c b/src/apps/LoRaMac/fuota-test-01/NucleoL152/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/NucleoL476/main.c b/src/apps/LoRaMac/fuota-test-01/NucleoL476/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/SAMR34/main.c b/src/apps/LoRaMac/fuota-test-01/SAMR34/main.c
@@ -200,7 +200,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/SKiM880B/main.c b/src/apps/LoRaMac/fuota-test-01/SKiM880B/main.c
@@ -210,7 +210,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/SKiM881AXL/main.c b/src/apps/LoRaMac/fuota-test-01/SKiM881AXL/main.c
@@ -210,7 +210,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/fuota-test-01/SKiM980A/main.c b/src/apps/LoRaMac/fuota-test-01/SKiM980A/main.c
@@ -210,7 +210,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/B-L072Z-LRWAN1/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/B-L072Z-LRWAN1/main.c
@@ -230,7 +230,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/NAMote72/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/NAMote72/main.c
@@ -223,7 +223,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/NucleoL073/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/NucleoL073/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/NucleoL152/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/NucleoL152/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/NucleoL476/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/NucleoL476/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/SAMR34/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/SAMR34/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/SKiM880B/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/SKiM880B/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/SKiM881AXL/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/SKiM881AXL/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/apps/LoRaMac/periodic-uplink-lpp/SKiM980A/main.c b/src/apps/LoRaMac/periodic-uplink-lpp/SKiM980A/main.c
@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =
 
 static LmhpComplianceParams_t LmhpComplianceParams =
 {
-    .IsDutFPort224On = true,
     .FwVersion.Value = FIRMWARE_VERSION,
     .OnTxPeriodicityChanged = OnTxPeriodicityChanged,
     .OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,
diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
@@ -152,11 +152,14 @@ typedef struct sLoRaMacNvmCtx
      * Counts the number of missed ADR acknowledgements
      */
     uint32_t AdrAckCounter;
-
     /*
      * LoRaMac parameters
      */
     LoRaMacParams_t MacParams;
+    /*
+     * Enables/disable FPort 224 processing (certification port)
+     */
+    bool IsCertPortOn;
     /*
      * Maximum duty cycle
      * \remark Possibility to shutdown the device.
@@ -1311,6 +1314,15 @@ static void ProcessRadioRxDone( void )
                     break;
             }
 
+            if( ( macMsgData.FPort == LORAMAC_CERT_FPORT ) && ( MacCtx.NvmCtx->IsCertPortOn == false ) )
+            { // Do not notify the upper layer of data reception on FPort LORAMAC_CERT_FPORT if the port
+              // handling is disabled.
+                MacCtx.McpsIndication.Port = macMsgData.FPort;
+                MacCtx.McpsIndication.Buffer = NULL;
+                MacCtx.McpsIndication.BufferSize = 0;
+                MacCtx.McpsIndication.RxData = false;
+            }
+
             // Provide always an indication, skip the callback to the user application,
             // in case of a confirmed downlink retransmission.
             MacCtx.MacFlags.Bits.McpsInd = 1;
@@ -3402,6 +3414,9 @@ LoRaMacStatus_t LoRaMacInitialization( LoRaMacPrimitives_t* primitives, LoRaMacC
     MacCtx.NvmCtx->MacParams.JoinAcceptDelay2 = MacCtx.NvmCtx->MacParamsDefaults.JoinAcceptDelay2;
     MacCtx.NvmCtx->MacParams.ChannelsNbTrans = MacCtx.NvmCtx->MacParamsDefaults.ChannelsNbTrans;
 
+    // FPort 224 is enabled by default.
+    MacCtx.NvmCtx->IsCertPortOn = true;
+
     InitDefaultsParams_t params;
     params.Type = INIT_TYPE_DEFAULTS;
     params.NvmCtx = NULL;
@@ -3734,6 +3749,11 @@ LoRaMacStatus_t LoRaMacMibGetRequestConfirm( MibRequestConfirm_t* mibGet )
             mibGet->Param.LrWanVersion.LoRaWanRegion = RegionGetVersion( );
             break;
         }
+        case MIB_IS_CERT_FPORT_ON:
+        {
+            mibGet->Param.IsCertPortOn = MacCtx.NvmCtx->IsCertPortOn;
+            break;
+        }
         default:
         {
             status = LoRaMacClassBMibGetRequestConfirm( mibGet );
@@ -4374,6 +4394,11 @@ LoRaMacStatus_t LoRaMacMibSetRequestConfirm( MibRequestConfirm_t* mibSet )
             }
             break;
         }
+        case MIB_IS_CERT_FPORT_ON:
+        {
+            MacCtx.NvmCtx->IsCertPortOn = mibSet->Param.IsCertPortOn;
+            break;
+        }
         default:
         {
             status = LoRaMacMibClassBSetRequestConfirm( mibSet );
diff --git a/src/mac/LoRaMac.h b/src/mac/LoRaMac.h
@@ -104,6 +104,13 @@ extern "C"
  */
 #define LORAMAC_CRYPTO_MULTICAST_KEYS   127
 
+/*!
+ * LoRaWAN compliance certification protocol port number.
+ *
+ * LoRaWAN Specification V1.x.x, chapter 4.3.2
+ */
+#define LORAMAC_CERT_FPORT 224
+
 /*!
  * End-Device activation type
  */
@@ -1221,6 +1228,7 @@ typedef struct sMlmeIndication
  * \ref MIB_NVM_CTXS                             | YES | YES
  * \ref MIB_ABP_LORAWAN_VERSION                  | NO  | YES
  * \ref MIB_LORAWAN_VERSION                      | YES | NO
+ * \ref MIB_IS_CERT_FPORT_ON                     | YES | YES
  *
  * The following table provides links to the function implementations of the
  * related MIB primitives:
@@ -1629,6 +1637,10 @@ typedef enum eMib
      * The allowed ranges are region specific. Please refer to \ref DR_0 to \ref DR_15 for details.
      */
      MIB_PING_SLOT_DATARATE,
+     /*!
+      * LoRaWAN certification FPort handling state (ON/OFF)
+      */
+     MIB_IS_CERT_FPORT_ON,
 }Mib_t;
 
 /*!
@@ -2050,6 +2062,12 @@ typedef union uMibParam
      * Related MIB type: \ref MIB_PING_SLOT_DATARATE
      */
     int8_t PingSlotDatarate;
+    /*!
+     * LoRaWAN certification FPort handling state (ON/OFF)
+     *
+     * Related MIB type: \ref MIB_IS_CERT_FPORT_ON
+     */
+    bool IsCertPortOn;
 }MibParam_t;
 
 /*!

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`#include <stdint.h>`
`23`	`23`	`#include <stdbool.h>`
`24`	`24`	`#include "board.h"`
	`25`	`+#include "NvmCtxMgmt.h"`
`25`	`26`	`#include "LoRaMacTest.h"`
`26`	`27`	`#include "LmHandler.h"`
`27`	`28`	`#include "LmhpCompliance.h"`
`@@ -261,6 +262,7 @@ static void LmhpComplianceProcess( void )`
`261`	`262`	`if( ComplianceTestState.IsResetCmdPending == true )`
`262`	`263`	`{`
`263`	`264`	`ComplianceTestState.IsResetCmdPending = false;`
	`265`	`+`
`264`	`266`	`// Call platform MCU reset API`
`265`	`267`	`BoardResetMcu( );`
`266`	`268`	`}`
`@@ -269,17 +271,13 @@ static void LmhpComplianceProcess( void )`
`269`	`271`	`static void LmhpComplianceOnMcpsIndication( McpsIndication_t* mcpsIndication )`
`270`	`272`	`{`
`271`	`273`	`uint8_t cmdIndex = 0;`
	`274`	`+ MibRequestConfirm_t mibReq;`
`272`	`275`
`273`	`276`	`if( ComplianceTestState.Initialized == false )`
`274`	`277`	`{`
`275`	`278`	`return;`
`276`	`279`	`}`
`277`	`280`
`278`		`- if( ComplianceParams->IsDutFPort224On == false )`
`279`		`- {`
`280`		`- return;`
`281`		`- }`
`282`		`-`
`283`	`281`	`// Increment the compliance certification protocol downlink counter`
`284`	`282`	`// Not counting downlinks on FPort 0`
`285`	`283`	`if( ( mcpsIndication->Port > 0 ) \|\| ( mcpsIndication->AckReceived == true ) )`
`@@ -447,8 +445,10 @@ static void LmhpComplianceOnMcpsIndication( McpsIndication_t* mcpsIndication )`
`447`	`445`	`}`
`448`	`446`	`case COMPLIANCE_DUT_FPORT_224_DISABLE_REQ:`
`449`	`447`	`{`
`450`		`- // TODO: Handle FPort 224 control NVM update`
`451`		`- ComplianceParams->IsDutFPort224On = false;`
	`448`	`+ mibReq.Type = MIB_IS_CERT_FPORT_ON;`
	`449`	`+ mibReq.Param.IsCertPortOn = false;`
	`450`	`+ LoRaMacMibSetRequestConfirm( &mibReq );`
	`451`	`+`
`452`	`452`	`ComplianceTestState.IsResetCmdPending = true;`
`453`	`453`	`break;`
`454`	`454`	`}`
`@@ -521,11 +521,6 @@ static void LmhpComplianceOnMlmeIndication( MlmeIndication_t* mlmeIndication )`
`521`	`521`	`return;`
`522`	`522`	`}`
`523`	`523`
`524`		`- if( ComplianceParams->IsDutFPort224On == false )`
`525`		`- {`
`526`		`- return;`
`527`		`- }`
`528`		`-`
`529`	`524`	`switch( mlmeIndication->MlmeIndication )`
`530`	`525`	`{`
`531`	`526`	`case MLME_BEACON_LOST:`
Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,6 @@ static LmHandlerParams_t LmHandlerParams =`
`230`	`230`
`231`	`231`	`static LmhpComplianceParams_t LmhpComplianceParams =`
`232`	`232`	`{`
`233`		`- .IsDutFPort224On = true,`
`234`	`233`	`.FwVersion.Value = FIRMWARE_VERSION,`
`235`	`234`	`.OnTxPeriodicityChanged = OnTxPeriodicityChanged,`
`236`	`235`	`.OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,`
Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,6 @@ static LmHandlerParams_t LmHandlerParams =`
`223`	`223`
`224`	`224`	`static LmhpComplianceParams_t LmhpComplianceParams =`
`225`	`225`	`{`
`226`		`- .IsDutFPort224On = true,`
`227`	`226`	`.FwVersion.Value = FIRMWARE_VERSION,`
`228`	`227`	`.OnTxPeriodicityChanged = OnTxPeriodicityChanged,`
`229`	`228`	`.OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,`
Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,6 @@ static LmHandlerParams_t LmHandlerParams =`
`220`	`220`
`221`	`221`	`static LmhpComplianceParams_t LmhpComplianceParams =`
`222`	`222`	`{`
`223`		`- .IsDutFPort224On = true,`
`224`	`223`	`.FwVersion.Value = FIRMWARE_VERSION,`
`225`	`224`	`.OnTxPeriodicityChanged = OnTxPeriodicityChanged,`
`226`	`225`	`.OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,6 @@ static LmHandlerParams_t LmHandlerParams =`
`200`	`200`
`201`	`201`	`static LmhpComplianceParams_t LmhpComplianceParams =`
`202`	`202`	`{`
`203`		`- .IsDutFPort224On = true,`
`204`	`203`	`.FwVersion.Value = FIRMWARE_VERSION,`
`205`	`204`	`.OnTxPeriodicityChanged = OnTxPeriodicityChanged,`
`206`	`205`	`.OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,`
Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,6 @@ static LmHandlerParams_t LmHandlerParams =`
`210`	`210`
`211`	`211`	`static LmhpComplianceParams_t LmhpComplianceParams =`
`212`	`212`	`{`
`213`		`- .IsDutFPort224On = true,`
`214`	`213`	`.FwVersion.Value = FIRMWARE_VERSION,`
`215`	`214`	`.OnTxPeriodicityChanged = OnTxPeriodicityChanged,`
`216`	`215`	`.OnTxFrameCtrlChanged = OnTxFrameCtrlChanged,`