Issue #1372 - Added a check to verify that SystemMaxRxError provided value is in the range 0..500 ms

mluis1 · mluis1 · commit b96e660137f5 · 2022-11-04T11:21:51.000+01:00
diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
@@ -4844,7 +4844,14 @@ LoRaMacStatus_t LoRaMacMibSetRequestConfirm( MibRequestConfirm_t* mibSet )
         }
         case MIB_SYSTEM_MAX_RX_ERROR:
         {
-            Nvm.MacGroup2.MacParams.SystemMaxRxError = Nvm.MacGroup2.MacParamsDefaults.SystemMaxRxError = mibSet->Param.SystemMaxRxError;
+            if( mibSet->Param.SystemMaxRxError <= 500 )
+            { // Only apply the new value if in range 0..500 ms else keep current value.
+                Nvm.MacGroup2.MacParams.SystemMaxRxError = Nvm.MacGroup2.MacParamsDefaults.SystemMaxRxError = mibSet->Param.SystemMaxRxError;
+            }
+            else
+            {
+                status = LORAMAC_STATUS_PARAMETER_INVALID;
+            }
             break;
         }
         case MIB_MIN_RX_SYMBOLS:

Original file line number	Diff line number	Diff line change
`@@ -4844,7 +4844,14 @@ LoRaMacStatus_t LoRaMacMibSetRequestConfirm( MibRequestConfirm_t* mibSet )`
`4844`	`4844`	`}`
`4845`	`4845`	`case MIB_SYSTEM_MAX_RX_ERROR:`
`4846`	`4846`	`{`
`4847`		`- Nvm.MacGroup2.MacParams.SystemMaxRxError = Nvm.MacGroup2.MacParamsDefaults.SystemMaxRxError = mibSet->Param.SystemMaxRxError;`
	`4847`	`+ if( mibSet->Param.SystemMaxRxError <= 500 )`
	`4848`	`+ { // Only apply the new value if in range 0..500 ms else keep current value.`
	`4849`	`+ Nvm.MacGroup2.MacParams.SystemMaxRxError = Nvm.MacGroup2.MacParamsDefaults.SystemMaxRxError = mibSet->Param.SystemMaxRxError;`
	`4850`	`+ }`
	`4851`	`+ else`
	`4852`	`+ {`
	`4853`	`+ status = LORAMAC_STATUS_PARAMETER_INVALID;`
	`4854`	`+ }`
`4848`	`4855`	`break;`
`4849`	`4856`	`}`
`4850`	`4857`	`case MIB_MIN_RX_SYMBOLS:`