Add new comments

mluis1 · mluis1 · commit c47b841e04d1 · 2017-04-10T14:59:20.000+02:00
diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
@@ -1368,6 +1368,10 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t
                                 ( DownLinkCounter != 0 ) )
                             {
                                 // Duplicated confirmed downlink. Skip indication.
+                                // In this case, the MAC layer shall accept the MAC commands
+                                // which are included in the downlink retransmission.
+                                // It should not provide the same frame to the application
+                                // layer again.
                                 skipIndication = true;
                             }
                         }
@@ -1404,6 +1408,7 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t
                         MacCommandsBufferIndex = 0;
                     }
 
+                    // Process payload and MAC commands
                     if( ( ( size - 4 ) - appPayloadStartIndex ) > 0 )
                     {
                         port = payload[appPayloadStartIndex++];
@@ -1413,6 +1418,7 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t
 
                         if( port == 0 )
                         {
+                            // Only allow frames which do not have fOpts
                             if( fCtrl.Bits.FOptsLen == 0 )
                             {
                                 LoRaMacPayloadDecrypt( payload + appPayloadStartIndex,

Original file line number	Diff line number	Diff line change
`@@ -1368,6 +1368,10 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t`
`1368`	`1368`	`( DownLinkCounter != 0 ) )`
`1369`	`1369`	`{`
`1370`	`1370`	`// Duplicated confirmed downlink. Skip indication.`
	`1371`	`+ // In this case, the MAC layer shall accept the MAC commands`
	`1372`	`+ // which are included in the downlink retransmission.`
	`1373`	`+ // It should not provide the same frame to the application`
	`1374`	`+ // layer again.`
`1371`	`1375`	`skipIndication = true;`
`1372`	`1376`	`}`
`1373`	`1377`	`}`
`@@ -1404,6 +1408,7 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t`
`1404`	`1408`	`MacCommandsBufferIndex = 0;`
`1405`	`1409`	`}`
`1406`	`1410`
	`1411`	`+ // Process payload and MAC commands`
`1407`	`1412`	`if( ( ( size - 4 ) - appPayloadStartIndex ) > 0 )`
`1408`	`1413`	`{`
`1409`	`1414`	`port = payload[appPayloadStartIndex++];`
`@@ -1413,6 +1418,7 @@ static void OnRadioRxDone( uint8_t *payload, uint16_t size, int16_t rssi, int8_t`
`1413`	`1418`
`1414`	`1419`	`if( port == 0 )`
`1415`	`1420`	`{`
	`1421`	`+ // Only allow frames which do not have fOpts`
`1416`	`1422`	`if( fCtrl.Bits.FOptsLen == 0 )`
`1417`	`1423`	`{`
`1418`	`1424`	`LoRaMacPayloadDecrypt( payload + appPayloadStartIndex,`