Fix register corruption due to colliding SPI transactions in FSK

mvds00 · mvds00 · commit e1a1a66e1c35 · 2023-07-16T02:51:05.000+02:00
In FSK Tx, the Dio1 interrupt may already fire while the SPI transaction for
SetOpMode is still in progress. This leads to registers 0x02 and further being
overwritten with junk data.

This is solved by disabling interrupts for this specific SetOpMode call.
diff --git a/src/radio/sx1276/sx1276.c b/src/radio/sx1276/sx1276.c
@@ -1125,7 +1125,9 @@ static void SX1276SetTx( uint32_t timeout )
 
     SX1276.Settings.State = RF_TX_RUNNING;
     TimerStart( &TxTimeoutTimer );
+    CRITICAL_SECTION_BEGIN();
     SX1276SetOpMode( RF_OPMODE_TRANSMITTER );
+    CRITICAL_SECTION_END();
 }
 
 void SX1276StartCad( void )

Original file line number	Diff line number	Diff line change
`@@ -1125,7 +1125,9 @@ static void SX1276SetTx( uint32_t timeout )`
`1125`	`1125`
`1126`	`1126`	`SX1276.Settings.State = RF_TX_RUNNING;`
`1127`	`1127`	`TimerStart( &TxTimeoutTimer );`
	`1128`	`+ CRITICAL_SECTION_BEGIN();`
`1128`	`1129`	`SX1276SetOpMode( RF_OPMODE_TRANSMITTER );`
	`1130`	`+ CRITICAL_SECTION_END();`
`1129`	`1131`	`}`
`1130`	`1132`
`1131`	`1133`	`void SX1276StartCad( void )`