-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathChange_suggestions
More file actions
32 lines (18 loc) · 1.2 KB
/
Change_suggestions
File metadata and controls
32 lines (18 loc) · 1.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
General:
- One template file, instead of for each city one
- If you really want them to differ, you could extract that to some xml-file (or json or DB) elsewhere instead of making a different php file for each one seperately
- Extracting strings (Eg. urls) to one file, it's like impossible
to move the site at this time.
- Creating a php-class for doing all the mongoDB requests and
parsing them to JSON-arrays that can be used in de data, so if you´d want to switch DB you'd just have to change one file.
- I'm not sure where the data/weather/weather.php and data/../air.
php etc get run?
- I believe the loadContent.js-file could be much shorter if
written more dynamically, (there are also a few weird thingies in here, I don't believe the refresh functions all work, 2 of the file extensions they're supposed to load are wrong)
- I think using PHP-Objects instead of JSON after downloading the
info would be more readable
- I'm not sure all the data retrieving files still work, sites and
api have changed
/data/airquality/airquality.php
- reads a whole HTML file (website) to get data, definitely not working anymore, why not
/widget/instagram not working because wrong url to php file