Skip to content

Commit 33a37e3

Browse files
committed
Interim Fixes
1 parent 08bcb81 commit 33a37e3

File tree

111 files changed

+1607
-679
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

111 files changed

+1607
-679
lines changed

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ All notable changes to `laravel-livewire-tables` will be documented in this file
204204
- In LaravelLivewireTablesEvent, change the type to Illuminate\Contracts\Auth\Authenticatable by @khwadj in https://github.com/rappasoft/laravel-livewire-tables/pull/1963
205205
- Fix for Search Field Attribute Defaults by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1962
206206
- Fix Filter Pills Icon - Tailwind by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1961
207-
- Add filterComponents into queryString to ensure they're maintained by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1957
207+
- Add appliedFilters into queryString to ensure they're maintained by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1957
208208
- Reset Current Page on "Per Page" changing by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1953
209209

210210
### New Features
@@ -302,7 +302,7 @@ All notable changes to `laravel-livewire-tables` will be documented in this file
302302

303303
## [v3.4.8] - 2024-08-18
304304
### New Features
305-
- Add an event dispatch for Filter Was Set when filterComponents is updated by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1861
305+
- Add an event dispatch for Filter Was Set when appliedFilters is updated by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1861
306306

307307
## [v3.4.7] - 2024-08-18
308308
### Bug Fixes
@@ -483,7 +483,7 @@ All notable changes to `laravel-livewire-tables` will be documented in this file
483483
- Fix collapsing columns not respecting view point collapse points by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1665
484484

485485
### Tweaks
486-
- Migrate "updated" Search and FilterComponents calls to WithSearch and WithFilters by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1666
486+
- Migrate "updated" Search and appliedFilters calls to WithSearch and WithFilters by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1666
487487
- Allow nullable search/filter values by @lrljoe in https://github.com/rappasoft/laravel-livewire-tables/pull/1666
488488

489489
## [v3.2.0] - 2024-01-04
@@ -697,7 +697,7 @@ All notable changes to `laravel-livewire-tables` will be documented in this file
697697
- DateFilter & DateTimeFilter fully support setFilterDefaultValue
698698
- MultiSelectFilter & MultiSelectDropdownFilter both support setFirstOption()
699699
- There are now two arrays relating to Filters:
700-
- A wireable one ($filterComponents)
700+
- A wireable one ($appliedFilters)
701701
- An unwired one - only keeps track of those filters that have a value ($appliedFilters). This is what is bound to the query string, and populates the filters on mount if they are present in the query string.
702702

703703
- Livewire 3 Specific

phpstan.neon

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ parameters:
1414
reportUnmatchedIgnoredErrors: false
1515
ignoreErrors:
1616
- identifier: argument.type
17+
- identifier: argument.templateType
1718
- identifier: new.static
1819
- identifier: trait.unused
19-
- identifier: deadCode.unreachable
2020
- identifier: booleanNot.alwaysTrue
2121
paths:
2222
- src/Views/Columns/Traits/HasDataTableComponent.php
@@ -26,19 +26,23 @@ parameters:
2626
- src/Traits/Helpers/CustomisationsHelpers.php
2727
- src/Traits/Helpers/QueryHelpers.php
2828
- src/Views/Columns/Traits/HasSlot.php
29-
- src/Views/Columns/Traits/Helpers/ArrayColumnHelpers.php
3029
- identifier: instanceof.alwaysTrue
3130
paths:
31+
- src/Traits/Helpers/ColumnHelpers.php
3232
- src/Views/Columns/Traits/HasFooter.php
3333
- src/Views/Columns/Traits/HasSecondaryHeader.php
3434
- identifier: function.alreadyNarrowedType
3535
paths:
36-
- src/Views/Columns/Traits/Helpers/ArrayColumnHelpers.php
37-
- src/Features/AutoInjectRappasoftAssets.php
38-
- src/Traits/WithBulkActions.php
39-
- src/Views/Actions/Traits/HasActionAttributes.php
4036
- src/Views/Filters/MultiSelectDropdownFilter.php
4137
- src/Views/Filters/Traits/HasOptions.php
42-
- src/Views/Traits/Core/HasTheme.php
4338
- src/Views/Traits/Core/HasView.php
39+
- identifier: missingType.generics
40+
paths:
41+
- src/Traits/WithData.php
42+
- identifier: empty.offset
43+
paths:
44+
- src/Traits/Filters/Helpers/FilterMenuHelpers.php
45+
- identifier: isset.offset
46+
paths:
47+
- src/Traits/Filters/Helpers/FilterMenuHelpers.php
4448
- message: '# \$view of function view expects view-string\|null, string given.#'

resources/js/partials/core/tools.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
function tools() {
44
Alpine.data('tools', (wire) => ({
5-
filtersOpen: wire.entangle('filterSlideDownDefaultVisible'),
5+
filtersOpen: wire.entangle('filterConfiguration.filterSlideDownDefaultVisible'),
66
externalFilterPillsVals: wire.entangle('externalFilterPillsValues'),
77
internalFilterPillsVals: wire.entangle('internalFilterPillsVals'),
8-
showFilterPillLabel: [],
8+
showFilterPillLabel: [],
99
filterPillsSeparator: ', ',
1010
showFilterPillsSection: true,
1111
resetSpecificFilter(filterKey)

resources/js/partials/core/tools.min.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
function tools() {
44
Alpine.data('tools', (wire) => ({
5-
filtersOpen: wire.entangle('filterSlideDownDefaultVisible'),
5+
filtersOpen: wire.entangle('filterConfiguration.filterSlideDownDefaultVisible'),
66
externalFilterPillsVals: wire.entangle('externalFilterPillsValues'),
77
internalFilterPillsVals: wire.entangle('internalFilterPillsVals'),
88
showFilterPillLabel: [],

resources/js/partials/filter-boolean.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
document.addEventListener('alpine:init', () => {
22
Alpine.data('booleanFilter', (wire,filterKey,tableName,defaultValue) => ({
33
switchOn: false,
4-
value: wire.entangle('filterComponents.'+filterKey).live,
4+
value: wire.entangle('appliedFilters.'+filterKey).live,
55
init() {
66
this.switchOn = false;
77
if (typeof this.value !== 'undefined') {

resources/js/partials/filter-boolean.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

resources/js/partials/filter-date-range.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
function fpf() {
44
Alpine.data('flatpickrFilter', (wire, filterKey, filterConfig, refLocation, locale) => ({
5-
wireValues: wire.entangle('filterComponents.' + filterKey),
5+
wireValues: wire.entangle('appliedFilters.' + filterKey),
66
flatpickrInstance: flatpickr(refLocation, {
77
mode: 'range',
88
altFormat: filterConfig['altFormat'] ?? "F j, Y",
@@ -36,7 +36,7 @@ function fpf() {
3636
window.childElementOpen = false;
3737
window.filterPopoverOpen = false;
3838
wireDateArray = { 'minDate': dates[0], 'maxDate': (typeof dates[2] === "undefined") ? dates[0] : dates[2] };
39-
wire.set('filterComponents.' + filterKey, wireDateArray);
39+
wire.set('appliedFilters.' + filterKey, wireDateArray);
4040
}
4141

4242
},

resources/js/partials/filter-date-range.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

resources/js/partials/filter-number-range.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
/*jshint esversion: 6 */
22
export function nrf() {
33
Alpine.data('numberRangeFilter', (wire, filterKey, parentElementPath, filterConfig, childElementRoot) => ({
4-
allFilters: wire.entangle('filterComponents', false),
4+
allFilters: wire.entangle('appliedFilters', false),
55
originalMin: 0,
66
originalMax: 100,
77
filterMin: 0,
88
filterMax: 100,
99
currentMin: 0,
1010
currentMax: 100,
1111
hasUpdate: false,
12-
wireValues: wire.entangle('filterComponents.' + filterKey, false),
12+
wireValues: wire.entangle('appliedFilters.' + filterKey, false),
1313
defaultMin: filterConfig['minRange'],
1414
defaultMax: filterConfig['maxRange'],
1515
restrictUpdates: false,
@@ -60,7 +60,7 @@ export function nrf() {
6060
if (this.hasUpdate) {
6161
this.hasUpdate = false;
6262
this.wireValues = { 'min': this.filterMin, 'max': this.filterMax };
63-
wire.set('filterComponents.' + filterKey, this.wireValues);
63+
wire.set('appliedFilters.' + filterKey, this.wireValues);
6464
}
6565
},
6666
init() {

resources/js/partials/filter-number-range.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)