Fix bug with FilterQueryString (rappasoft#2014)

lrljoe · web-flow · commit 92dc8fb6ea87 · 2024-10-25T21:19:21.000+01:00
* Fix bug with FilterQueryString

* Fix styling

---------

Co-authored-by: lrljoe &lt;lrljoe@users.noreply.github.com&gt;
diff --git a/src/Traits/Core/QueryStrings/HasQueryStringForFilter.php b/src/Traits/Core/QueryStrings/HasQueryStringForFilter.php
@@ -44,7 +44,7 @@ public function queryStringForFilterIsEnabled(): bool
     {
         $this->setupQueryStringStatusForFilter();
 
-        return ($this->queryStringIsEnabled() === true || $this->getQueryStringStatusForFilter() === true) && $this->filtersAreEnabled();
+        return $this->getQueryStringStatusForFilter() && $this->filtersAreEnabled();
     }
 
     public function setQueryStringStatusForFilter(bool $status): self

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function queryStringForFilterIsEnabled(): bool`
`44`	`44`	`{`
`45`	`45`	`$this->setupQueryStringStatusForFilter();`
`46`	`46`
`47`		`- return ($this->queryStringIsEnabled() === true \|\| $this->getQueryStringStatusForFilter() === true) && $this->filtersAreEnabled();`
	`47`	`+ return $this->getQueryStringStatusForFilter() && $this->filtersAreEnabled();`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`public function setQueryStringStatusForFilter(bool $status): self`