Clean up DateRangeFilter - broken pills, and missing test

Author: lrljoe

src/Views/Filters/DateRangeFilter.php

@@ -40,12 +40,10 @@ public function validate(array|string|null $values): array|bool
             return false;
         }
 
-        $startDate = $this->createCarbonDate($returnedValues['minDate']);
-        $endDate = $this->createCarbonDate($returnedValues['maxDate']);
-
-        if (! ($startDate instanceof Carbon) || ! ($endDate instanceof Carbon)) {
+        if (! (($startDate = $this->createCarbonDate($returnedValues['minDate'])) instanceof Carbon) || ! (($endDate = $this->createCarbonDate($returnedValues['maxDate'])) instanceof Carbon)) {
             return false;
         }
+        
         if ($startDate->gt($endDate)) {
             return false;
         }

tests/Unit/Views/Filters/DateRangeFilterTest.php

@@ -453,5 +453,10 @@ public function test_can_check_validation_rejects_invalid_values_array(): void
     public function test_can_check_validation_rejects_broken_values_array(): void
     {
         $this->assertFalse(self::$filterInstance->validate(['minDate' => 'asdf', 'maxDate' => '2020-02-02']));
+        $this->assertFalse(self::$filterInstance->validate(['minDate' => '4121-31-31', 'maxDate' => '2020-02-02']));
+        $this->assertFalse(self::$filterInstance->validate(['minDate' => '2020-02-02', 'maxDate' => 'asdf']));
+        $this->assertFalse(self::$filterInstance->validate(['minDate' => '2020-02-02', 'maxDate' => '4121-31-31']));
+
+
     }
 }