Test Fixes

Author: lrljoe

phpunit.xml.dist

@@ -9,10 +9,6 @@
          failOnEmptyTestSuite="false" 
          beStrictAboutOutputDuringTests="true" >
     <testsuites>
-        <testsuite name="Laravel Livewire Tables Unit and Visuals Test Suite">
-            <directory>tests/Unit</directory>
-            <directory>tests/Visuals</directory>
-        </testsuite>
         <testsuite name="Laravel Livewire Tables Unit Test Suite">
             <directory>tests/Unit</directory>
         </testsuite>

tests/Unit/DataTransferObjects/DebuggableDataTest.php

@@ -25,7 +25,13 @@ public function test_check_all_default_dto_elements()
 
         $defaultQuery = 'select "pets"."id" as "id", "pets"."sort" as "sort", "pets"."name" as "name", "pets"."age" as "age", "breed"."name" as "breed.name", "pets"."last_visit" as "last_visit" from "pets" left join "breeds" as "breed" on "pets"."breed_id" = "breed"."id" limit 10 offset 0';
         $this->assertSame($debuggableArray['query'], $defaultQuery);
-        $this->assertSame($debuggableArray['filters'], []);
+        $this->assertSame($debuggableArray['filters'], ['breed' => [],
+        'species' => [],
+        'breed_id_filter' => null,
+        'pet_name_filter' => null,
+        'last_visit_date_filter' => null,
+        'last_visit_datetime_filter' => null,
+        'breed_select_filter' => null]);
         $this->assertSame($debuggableArray['sorts'], []);
         $this->assertSame($debuggableArray['search'], '');
         $this->assertFalse($debuggableArray['select-all']);
@@ -36,12 +42,24 @@ public function test_check_dto_returns_filters_correctly()
     {
         $debuggableDTO = new DebuggableData($this->basicTable);
         $debuggableArray = $debuggableDTO->toArray();
-        $this->assertSame($debuggableArray['filters'], []);
+        $this->assertSame($debuggableArray['filters'], ['breed' => [],
+        'species' => [],
+        'breed_id_filter' => null,
+        'pet_name_filter' => null,
+        'last_visit_date_filter' => null,
+        'last_visit_datetime_filter' => null,
+        'breed_select_filter' => null]);
 
         $this->basicTable->setFilter('breed', ['1']);
         $debuggableDTO = new DebuggableData($this->basicTable);
         $debuggableArray = $debuggableDTO->toArray();
-        $this->assertSame($debuggableArray['filters'], ['breed' => ['1']]);
+        $this->assertSame($debuggableArray['filters'], ['breed' => ["1"],
+        'species' => [],
+        'breed_id_filter' => null,
+        'pet_name_filter' => null,
+        'last_visit_date_filter' => null,
+        'last_visit_datetime_filter' => null,
+        'breed_select_filter' => null]);
 
     }
 }

tests/Unit/Traits/Helpers/ColumnSelectHelpersTest.php

@@ -157,10 +157,11 @@ public function configure(): void
                 $this->enableColumnSelectEvent();
             }
         };
+        $testTable->mountManagesFilters();
         $testTable->configure();
         $testTable->boot();
         $testTable->bootedComponentUtilities();
-        $testTable->bootedWithData();
+        $testTable->bootedManagesFilters();
         $testTable->bootedWithColumns();
         $testTable->bootedWithColumnSelect();
         $testTable->bootedWithSecondaryHeader();
@@ -187,10 +188,11 @@ public function configure(): void
                 $this->disableColumnSelectEvent();
             }
         };
+        $testTable->mountManagesFilters();
         $testTable->configure();
         $testTable->boot();
+        $testTable->bootedManagesFilters();
         $testTable->bootedComponentUtilities();
-        $testTable->bootedWithData();
         $testTable->bootedWithColumns();
         $testTable->bootedWithColumnSelect();
         $testTable->bootedWithSecondaryHeader();

tests/Unit/Traits/WithCustomisationsTest.php

@@ -96,7 +96,6 @@ public function configure(): void
         $temp->boot();
         $temp->bootedComponentUtilities();
         $temp->bootedManagesFilters();
-        $temp->bootedWithData();
         $temp->bootedWithColumns();
         $temp->bootedWithColumnSelect();
         $temp->bootedWithSecondaryHeader();
@@ -130,7 +129,6 @@ public function configure(): void
 
         $temp->boot();
         $temp->bootedComponentUtilities();
-        $temp->bootedWithData();
         $temp->bootedWithColumns();
         $temp->bootedWithColumnSelect();
         $temp->bootedWithSecondaryHeader();

tests/Unit/Traits/WithMountTest.php

@@ -31,8 +31,9 @@ public function test_mounttable_gets_correct_first_item(): void
         $table2 = new PetsTableMount;
         $table2->boot();
         $table2->mount(202);
+        $table2->mountManagesFilters();
         $table2->bootedComponentUtilities();
-        $table2->bootedWithData();
+        $table2->bootedManagesFilters();
         $table2->bootedWithColumns();
         $table2->bootedWithColumnSelect();
         $table2->bootedWithSecondaryHeader();
@@ -47,8 +48,9 @@ public function test_mounttable_gets_correct_first_item(): void
         $table3 = new PetsTableMount;
         $table3->boot();
         $table3->mount();
+        $table3->mountManagesFilters();
+        $table3->bootedManagesFilters();
         $table3->bootedComponentUtilities();
-        $table3->bootedWithData();
         $table3->bootedWithColumns();
         $table3->bootedWithColumnSelect();
         $table3->bootedWithSecondaryHeader();

tests/Unit/Traits/WithSearchTest.php

@@ -53,7 +53,7 @@ public function configure(): void
         $testTableDefault->configure();
         $testTableDefault->boot();
         $testTableDefault->bootedComponentUtilities();
-        $testTableDefault->bootedWithData();
+        $testTableDefault->bootedManagesFilters();
         $testTableDefault->bootedWithColumns();
         $testTableDefault->bootedWithColumnSelect();
         $testTableDefault->bootedWithSecondaryHeader();
@@ -90,10 +90,11 @@ public function configure(): void
             }
         };
 
+        $testTableTrimSearch->mountManagesFilters();
         $testTableTrimSearch->configure();
         $testTableTrimSearch->boot();
         $testTableTrimSearch->bootedComponentUtilities();
-        $testTableTrimSearch->bootedWithData();
+        $testTableTrimSearch->bootedManagesFilters();
         $testTableTrimSearch->bootedWithColumns();
         $testTableTrimSearch->bootedWithColumnSelect();
         $testTableTrimSearch->bootedWithSecondaryHeader();