Skip to content

Commit f28ca23

Browse files
committed
Performance Tweaks
1 parent f960d15 commit f28ca23

File tree

3 files changed

+24
-19
lines changed

3 files changed

+24
-19
lines changed

resources/views/components/tools/toolbar/items/bulk-actions.blade.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828

2929

3030
@if($isTailwind)
31-
x-on:click="open = !open"
32-
@else
33-
data-toggle="dropdown" data-bs-toggle="dropdown"
34-
@endif
31+
x-on:click="open = !open"
32+
@else
33+
data-toggle="dropdown" data-bs-toggle="dropdown"
34+
@endif
3535
aria-haspopup="true" aria-expanded="false">
3636

3737
{{ __($localisationPath.'Bulk Actions') }}

resources/views/components/tools/toolbar/items/filter-popover.blade.php

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
1-
@aware(['tableName'])
2-
@if($this->isBootstrap)
1+
@aware(['tableName','isBootstrap','isBootstrap4','isBootstrap5'])
2+
@php($filterPopoverAttributes = $this->getFilterPopoverAttributes())
3+
@php($filterGenericData = $this->getFilterGenericData())
4+
5+
@if($isBootstrap)
36
<ul x-cloak {{ $attributes
4-
->merge($this->getFilterPopoverAttributes())
7+
->merge($filterPopoverAttributes)
58
->merge(['role' => 'menu'])
69
->class([
7-
'w-100' => $this->getFilterPopoverAttributes['default-width'] ?? true,
8-
'dropdown-menu mt-md-5' => $this->isBootstrap4,
9-
'dropdown-menu' => $this->isBootstrap5,
10+
'w-100' => $filterPopoverAttributes['default-width'] ?? true,
11+
'dropdown-menu mt-md-5' => $isBootstrap4,
12+
'dropdown-menu' => $isBootstrap5,
1013
]) }} x-bind:class="{ 'show': filterPopoverOpen }">
1114
@foreach ($this->getVisibleFilters() as $filter)
1215
<div id="{{ $tableName }}-filter-{{ $filter->getKey() }}-wrapper" wire:key="{{ $tableName }}-filter-{{ $filter->getKey() }}-toolbar" class="p-2">
13-
{{ $filter->setGenericDisplayData($this->getFilterGenericData())->render() }}
16+
{{ $filter->setGenericDisplayData($filterGenericData)->render() }}
1417
</div>
1518
@endforeach
1619

@@ -23,7 +26,7 @@
2326
<div x-cloak x-show="filterPopoverOpen"
2427
{{
2528
$attributes
26-
->merge($this->getFilterPopoverAttributes())
29+
->merge($filterPopoverAttributes)
2730
->merge([
2831
'role' => 'menu',
2932
'aria-orientation' => 'vertical',
@@ -36,17 +39,17 @@
3639
'x-transition:leave-end' => 'transform opacity-0 scale-95',
3740
])
3841
->class([
39-
'w-full md:w-56' => $this->getFilterPopoverAttributes()['default-width'] ?? true,
40-
'origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50' => $this->getFilterPopoverAttributes()['default-styling'] ?? true,
41-
'bg-white divide-gray-100 ring-black dark:bg-gray-700 dark:text-white dark:divide-gray-600' => $this->getFilterPopoverAttributes()['default-colors'] ?? true,
42+
'w-full md:w-56' => $filterPopoverAttributes['default-width'] ?? true,
43+
'origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50' => $filterPopoverAttributes['default-styling'] ?? true,
44+
'bg-white divide-gray-100 ring-black dark:bg-gray-700 dark:text-white dark:divide-gray-600' => $filterPopoverAttributes['default-colors'] ?? true,
4245
])
4346
->except(['x-cloak', 'x-show', 'default','default-width', 'default-styling','default-colors'])
4447
}}>
4548

4649
@foreach ($this->getVisibleFilters() as $filter)
4750
<div class="py-1" role="none">
4851
<div id="{{ $tableName }}-filter-{{ $filter->getKey() }}-wrapper" wire:key="{{ $tableName }}-filter-{{ $filter->getKey() }}-toolbar" class="block px-4 py-2 text-sm text-gray-700 space-y-1" role="menuitem">
49-
{{ $filter->setGenericDisplayData($this->getFilterGenericData())->render() }}
52+
{{ $filter->setGenericDisplayData($filterGenericData)->render() }}
5053
</div>
5154
</div>
5255
@endforeach

resources/views/components/tools/toolbar/items/filter-slidedown.blade.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
@aware([ 'tableName', 'isTailwind', 'isBootstrap'])
22
@props([])
3+
@php($filterSlidedownWrapperAttributes = $this->getFilterSlidedownWrapperAttributes())
4+
@php($filterGenericData = $this->getFilterGenericData())
35

46
<div x-cloak x-show="filtersOpen" {{ $attributes
5-
->merge($this->getFilterSlidedownWrapperAttributes())
7+
->merge($filterSlidedownWrapperAttributes)
68
->merge($isTailwind ? [
79
'x-transition:enter' => 'transition ease-out duration-100',
810
'x-transition:enter-start' => 'transform opacity-0',
@@ -12,7 +14,7 @@
1214
'x-transition:leave-end' => 'transform opacity-0',
1315
] : [])
1416
->class([
15-
'container' => $isBootstrap && ($this->getFilterSlidedownWrapperAttributes()['default'] ?? true),
17+
'container' => $isBootstrap && ($filterSlidedownWrapperAttributes['default'] ?? true),
1618
])
1719
->except(['default','default-colors','default-styling'])
1820
}}
@@ -68,7 +70,7 @@
6870
])
6971
id="{{ $tableName }}-filter-{{ $filter->getKey() }}-wrapper"
7072
>
71-
{{ $filter->setGenericDisplayData($this->getFilterGenericData)->render() }}
73+
{{ $filter->setGenericDisplayData($filterGenericData)->render() }}
7274
</div>
7375
@endforeach
7476
</div>

0 commit comments

Comments
 (0)