Optimize ready players

Author: Lpsd

server/classes/conguard.lua

@@ -30,7 +30,7 @@ function ConGuard:constructor(dimension, settings)
     ConGuardInstances[dimension] = self
     iprintd("[ConGuard] Created instance in dimension " .. dimension)
 
-    triggerClientEvent(READY_PLAYERS, "onConGuardCreated", resourceRoot, dimension, self.settings)
+    triggerClientEvent(getReadyPlayers(), "onConGuardCreated", resourceRoot, dimension, self.settings)
 
     for i, player in ipairs(getElementsByType("player")) do
         if (not isPlayerReady(player)) then
@@ -47,7 +47,7 @@ function ConGuard:destructor()
     ConGuardInstances[self.dimension] = nil
     iprintd("[ConGuard] Destroyed instance in dimension " .. self.dimension)
 
-    triggerClientEvent(READY_PLAYERS, "onConGuardDestroyed", resourceRoot, self.dimension)
+    triggerClientEvent(getReadyPlayers(), "onConGuardDestroyed", resourceRoot, self.dimension)
 end
 
 -- *********************************************
@@ -88,7 +88,7 @@ end
 function ConGuard:setSetting(setting, value)
     self.settings[setting] = value
 
-    triggerClientEvent(READY_PLAYERS, "onConGuardSettingChange", resourceRoot, self.dimension, setting, value)
+    triggerClientEvent(getReadyPlayers(), "onConGuardSettingChange", resourceRoot, self.dimension, setting, value)
 
     return true
 end

server/main.lua

@@ -52,17 +52,23 @@ end
 -- *********************************************
 
 function isPlayerReady(player)
-    for i, p in ipairs(READY_PLAYERS) do
-        if (p == player) then
-            return true
-        end
-    end
+    return READY_PLAYERS[player] and true or false
+end
 
-    return false
+function getReadyPlayers()
+    local players = {}
+    for player in pairs(READY_PLAYERS) do
+        players[#players+1] = player
+    end
+    return players
 end
 
 function addPlayer(player)
-    table.insert(READY_PLAYERS, player)
+    if (READY_PLAYERS[player]) then
+        return
+    end
+
+    READY_PLAYERS[player] = true
     syncAll(player)
 end
 
@@ -74,11 +80,5 @@ function removePlayer()
     end
 
     instance:onPlayerNetworkStatus(1)
-
-    for i, player in ipairs(READY_PLAYERS) do
-        if (player == source) then
-            table.remove(READY_PLAYERS, i)
-            break
-        end
-    end
+    READY_PLAYERS[source] = nil
 end