Should I remove the Displayed Signals view? #99
Closed
Lramseyer
started this conversation in
Design Opinions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In short, I am thinking of getting rid of the Displayed Signals view and moving away from checkboxes entirely in the Netlist view. If you disagree with this plan, please let me know, otherwise, your beloved feature may be removed. The functionality that the checkboxes and a Displayed Signals view fulfilled are now re-implemented in other, better ways, so I think it's time to remove them and reduce code complexity.
In 1.4.1, I have added inline "+" buttons that can be clicked on to add a variable that I would like to replace the checkboxes with. I also added a drag and drop controller so that you can drag netlist variables into the viewer to add them. It's even drop location aware!
Rationale
In the early days of Vaporview (version 1.0, 1.1) I didn't really know what I was doing, and it was kind of difficult to remove variables from the viewer. I didn't have the delete key handler, nor did I have right click menus implemented. So the best way I could allow users to easily remove variables, was to create a secondary view with a list of the signals added to the viewer, which they could uncheck to remove.
To this day, Vaporview only allows users to add only one instance of a variable into the viewer, and I'm pretty sure that literally every other waveform viewer allows you to add as many instances of a signal as you want. Previously, everything was indexed by Netlist ID (Variable ID for wellen/surfer users.) But then groups came along (and signal spacers will probably follow soon) and those don't have Netlist IDs. So I had to move to something else.
At this point, there's no reason to not allow users to only have one instance of a variable in the viewer. But the checkboxes and the Displayed Signals View make that a little challenging, since users probably don't want to remove all instances of a variable if they uncheck the box.
Let me know your thoughts, and cast your votes. But please make sure that you have used version 1.4.1 before voting.
👍 - Remove it
👎 - Keep it
Beta Was this translation helpful? Give feedback.
All reactions