fix #1363 don't lookup globals in blocks

Author: sumneko

changelog.md

@@ -5,6 +5,7 @@
 * `CHG` improve supports for multi-workspace
 * `FIX` [#1354](https://github.com/sumneko/lua-language-server/issues/1354)
 * `FIX` [#1355](https://github.com/sumneko/lua-language-server/issues/1355)
+* `FIX` [#1363](https://github.com/sumneko/lua-language-server/issues/1363)
 * `FIX` [#1368](https://github.com/sumneko/lua-language-server/issues/1368)
 
 ## 3.5.0

script/core/diagnostics/unreachable-code.lua

@@ -50,9 +50,6 @@ return function (uri, callback)
     ---@async
     guide.eachSourceTypes(state.ast, {'main', 'function'}, function (source)
         await.delay()
-        if not source.returns then
-            return
-        end
         for i, action in ipairs(source) do
             if  guide.isBlockType(action)
             and hasReturn(action) then

script/vm/compiler.lua

@@ -1736,7 +1736,7 @@ local function compileByGlobal(source)
     if global.cate == 'variable' then
         local hasMarkDoc
         for _, set in ipairs(global:getSets(uri)) do
-            if set.bindDocs then
+            if set.bindDocs and set.parent.type == 'main' then
                 if bindDocs(set) then
                     globalNode:merge(vm.compileNode(set))
                     hasMarkDoc = true
@@ -1751,7 +1751,7 @@ local function compileByGlobal(source)
             vm.setNode(set, globalNode, true)
         end
         for _, set in ipairs(global:getSets(uri)) do
-            if set.value and set.value.type ~= 'nil' then
+            if set.value and set.value.type ~= 'nil' and set.parent.type == 'main' then
                 if not hasMarkDoc or guide.isLiteral(set.value) then
                     globalNode:merge(vm.compileNode(set.value))
                 end

test/diagnostics/common.lua

@@ -1987,6 +1987,28 @@ function X()
 end
 ]]
 
+TEST [[
+while true do
+end
+
+<!print(1)!>
+]]
+
+TEST [[
+while true do
+end
+
+<!print(1)!>
+]]
+
+TEST [[
+while X do
+    X = 1
+end
+
+print(1)
+]]
+
 TEST [[
 ---@diagnostic disable: undefined-global