fix #842

Author: sumneko

changelog.md

@@ -1,6 +1,7 @@
 # changelog
 
 ## 2.5.3
+* `FIX` [#842](https://github.com/sumneko/lua-language-server/issues/844)
 * `FIX` [#844](https://github.com/sumneko/lua-language-server/issues/844)
 
 ## 2.5.2

script/core/completion/completion.lua

@@ -1354,20 +1354,6 @@ local function getCallEnumsAndFuncs(source, index, oop, call)
         end
     end
     if source.type == 'doc.type.function' then
-        --[[
-        always use literal index, that is:
-        ```
-        ---@class Class
-        ---@field f(x: number, y: boolean)
-        local c
-
-        c.f(1, true) -- correct
-        c:f(1, true) -- also correct
-        ```
-        --]]
-        if oop then
-            index = index - 1
-        end
         local arg = source.args[index]
         if arg and arg.extends then
             return pushCallEnumsAndFuncs(vm.getDefs(arg.extends))

test/completion/common.lua

@@ -2593,7 +2593,7 @@ c:<??>
 
 TEST [[
 ---@class Class
----@field on fun(x: "'aaa'"|"'bbb'")
+---@field on fun(self, x: "'aaa'"|"'bbb'")
 local c
 
 c:on(<??>)
@@ -2605,7 +2605,7 @@ TEST [[
 ---@field on fun(x: "'aaa'"|"'bbb'")
 local c
 
-c:on('<??>')
+c.on('<??>')
 ]]
 (EXISTS)
 
@@ -3037,3 +3037,26 @@ end)
         }
     },
 }
+
+TEST [[
+---@meta
+
+---@alias testAlias
+---| "'test1'"
+---| "'test2'"
+---| "'test3'"
+
+---@class TestClass
+local TestClass = {}
+
+---@overload fun(self: TestClass, arg2: testAlias)
+---@param arg1 integer
+---@param arg2 testAlias
+function TestClass:testFunc2(arg1, arg2) end
+
+---@type TestClass
+local t
+
+t:testFunc2(<??>)
+]]
+(EXISTS)