test(diagnostics): the function node on a method isn't a direct ancestor in the ast so just wrap the args and name in the diagnostic for missing-export-doc

Author: NathanSnail

script/core/diagnostics/helper/missing-doc-helper.lua

@@ -107,7 +107,7 @@ end
 ---@param returnId string
 local function checkMethod(source, callback, commentId, paramId, returnId)
     local functionName = source.method[1]
-    checkFunctionNamed(functionName, source.value, source.method, nil, callback, commentId, paramId, returnId)
+    checkFunctionNamed(functionName, source.value, source, nil, callback, commentId, paramId, returnId)
 end
 
 m.CheckFunction = checkFunction

script/core/diagnostics/missing-export-doc.lua

@@ -19,7 +19,13 @@ return function (uri, callback)
     guide.eachSourceType(state.ast, 'setfield', function (source)
         await.delay()
         if source.value.type ~= "function" then return end
-        helper.CheckFunctionNamed(source.field[1], source.value, nil, source, callback,
+
+        -- TODO: find a better way to distinguish a.b = function and function a.b, or alternatively make them both work
+        -- the same way?
+        -- the issue is they have very similar ASTs but bindDocs is either inside or outside value
+
+        helper.CheckFunctionNamed(source.field[1], source.value, nil, source.bindDocs and source or source.value,
+            callback,
             'DIAG_MISSING_EXPORTED_FIELD_DOC_COMMENT',
             'DIAG_MISSING_EXPORTED_FIELD_DOC_PARAM',
             'DIAG_MISSING_EXPORTED_FIELD_DOC_RETURN')

test/diagnostics/missing-export-doc.lua

@@ -70,7 +70,7 @@ end
 TEST [[
 local M = {}
 
-<!function M:f1() end!>
+function <!M:f1()!> end
 
 ---comment
 function M:f2()