Requesting for a feature adjustment: no semantic highlighting on comments

[drcxd]

Currently lua ls provides semantic token highlighting to comments, this will override other font modifications applied on comments.

Could lua ls just leave comments and does not provide any semantic token highlighting information to the client?

For example, I am using lua ls with lsp-mode in Emacs:

and Emacs reports that the characters in TODO has the text property lsp-face-semhl-comment, which I believe is informed by the server.

Here is another example with clangd + lsp-mode in Emacs:

The face (an Emacs jargon, basically means how a character is displayed, its color, font, is it bold? italic? etc..) of TODO is applied by another package that identifies certain pattern in comments and change thier appearance. It seems that clangd does not provide any semantic token highlighting information for comments, and I hope lua ls may also adapt this pattern.

My point is that most editors can identify comments without the help of language server correctly and have applied corresponding highlighting for them. Inforcing the highlighting by a language server is not wrong but feels unnecessary to me and also, in this case, this prevents other packages on the editor from further processing the comments.

What do you think about this suggestion?

[tomlau10]

maybe this is what you want? #3081 (comment)
=> disable semantic.annotation in your config

---

My point is that most editors can identify comments without the help of language server correctly and have applied corresponding highlighting for them. Inforcing the highlighting by a language server is not wrong but feels unnecessary to me

AFAIK, luals uses LuaCAT annotation syntax, which are just comments in lua. So it needs to process the token types in comments, otherwise you won't have any highlight on the following:

---@param a integer some param desc for a
---@param b integer some param desc for b
function add(a, b) end

=> they will be all in grey (but maybe that's what you want, like the author in the discussion link)

[drcxd]

Thanks @tomlau10 . I forgot about the annotation syntax since I barely use them.

I am wondering if it is proper to built that into the language server since it is not part of the language.