From e29736589e0b6787e9dcaa156defbfdbdddb1865 Mon Sep 17 00:00:00 2001 From: Jakit Liang Date: Mon, 13 Jan 2025 05:10:00 +0800 Subject: [PATCH 1/3] `duplicate-index` and `duplicate-set-field` change to disabled by default. --- script/proto/diagnostic.lua | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/script/proto/diagnostic.lua b/script/proto/diagnostic.lua index 61b8ff4bd..c2a2622f2 100644 --- a/script/proto/diagnostic.lua +++ b/script/proto/diagnostic.lua @@ -203,16 +203,16 @@ m.register { 'duplicate-index', } { group = 'duplicate', - severity = 'Warning', - status = 'Any', + severity = 'Information', + status = 'None', } m.register { 'duplicate-set-field', } { group = 'duplicate', - severity = 'Warning', - status = 'Opened', + severity = 'Information', + status = 'None', } m.register { From df06858167f17408461dcc8a2cf770717a8c7306 Mon Sep 17 00:00:00 2001 From: Jakit Liang Date: Mon, 13 Jan 2025 05:21:00 +0800 Subject: [PATCH 2/3] Update changelog about the changing of diagnostics settings --- changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.md b/changelog.md index 8b5f93f76..44bd023ac 100644 --- a/changelog.md +++ b/changelog.md @@ -13,6 +13,7 @@ ``` * `NEW` Test CLI: `--name=` `-n=`: run specify unit test * `FIX` Fixed the error that the configuration file pointed to by the `--configpath` option was not read and loaded. +* `CHG` The diagnotics check of `duplicate-index` and `duplicate-set-field` features are disabled by default. ## 3.13.5 `2024-12-20` From 14e577ed3a5d16d648af40ae0d79f0524e03e5fc Mon Sep 17 00:00:00 2001 From: Jakit Liang Date: Mon, 13 Jan 2025 06:54:45 +0800 Subject: [PATCH 3/3] According to some opnion, change the severity back to Warning. --- script/proto/diagnostic.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/script/proto/diagnostic.lua b/script/proto/diagnostic.lua index c2a2622f2..c591ac4f7 100644 --- a/script/proto/diagnostic.lua +++ b/script/proto/diagnostic.lua @@ -203,7 +203,7 @@ m.register { 'duplicate-index', } { group = 'duplicate', - severity = 'Information', + severity = 'Warning', status = 'None', } @@ -211,7 +211,7 @@ m.register { 'duplicate-set-field', } { group = 'duplicate', - severity = 'Information', + severity = 'Warning', status = 'None', }