refactor: send addons in chunks instead of pages

Author: carsakiller

…/addon_manager/commands/getAddonsPage.ts …/src/addon_manager/commands/getAddons.tsclient/src/addon_manager/commands/getAddonsPage.ts renamed to client/src/addon_manager/commands/getAddons.ts client/src/addon_manager/commands/getAddonsPage.ts renamed to client/src/addon_manager/commands/getAddons.ts

@@ -6,15 +6,9 @@ import { ADDONS_DIRECTORY } from "../config";
 
 const localLogger = createChildLogger("Get Remote Addons");
 
-type Message = {
-    data: { page: number; pageSize?: number };
-};
-
-export default async (context: vscode.ExtensionContext, message: Message) => {
+export default async (context: vscode.ExtensionContext) => {
     WebVue.setLoadingState(true);
 
-    const { page, pageSize } = message.data;
-
     const installLocation = vscode.Uri.joinPath(
         context.globalStorageUri,
         "addonManager",
@@ -36,10 +30,19 @@ export default async (context: vscode.ExtensionContext, message: Message) => {
         return;
     }
 
-    const addonList = await addonManager.getAddonsPage(page, pageSize ?? 10);
+    /** Number of addons to load per chunk */
+    const CHUNK_SIZE = 30;
 
-    const addons = await Promise.all(addonList.map((addon) => addon.toJSON()));
+    // Get list of addons and sort them alphabetically
+    const addonList = Array.from(addonManager.addons.values());
+    addonList.sort((a, b) => a.displayName.localeCompare(b.displayName));
+
+    // Send addons to client in chunks
+    for (let i = 0; i <= addonList.length / CHUNK_SIZE; i++) {
+        const chunk = addonList.slice(i * CHUNK_SIZE, i * CHUNK_SIZE + CHUNK_SIZE);
+        const addons = await Promise.all(chunk.map((addon) => addon.toJSON()));
+        await WebVue.sendMessage("addAddon", { addons });
+    }
 
-    WebVue.sendMessage("addAddon", { addons });
     WebVue.setLoadingState(false);
 };

client/src/addon_manager/commands/index.ts

@@ -1,7 +1,7 @@
 import enable from "./enable";
 import disable from "./disable";
 import open from "./open";
-import getAddonsPage from "./getAddonsPage";
+import getAddons from "./getAddons";
 import refreshAddons from "./refreshAddons";
 import openLog from "./openLog";
 import update from "./update";
@@ -11,7 +11,7 @@ export const commands = {
     enable,
     disable,
     open,
-    getAddonsPage,
+    getAddons,
     refreshAddons,
     openLog,
     update,

client/src/addon_manager/services/addonManager.service.ts

@@ -25,16 +25,6 @@ class AddonManager {
         return await this.checkUpdated();
     }
 
-    /** Get a page of local addons */
-    public getAddonsPage(page: number, pageSize: number): Addon[] {
-        const start = (page - 1) * pageSize;
-        const addons = Array.from(this.addons.values());
-
-        addons.sort((a, b) => a.displayName.localeCompare(b.displayName));
-
-        return addons.slice(start, start + pageSize);
-    }
-
     public async checkUpdated() {
         const diff = await git.diffSummary([
             "main",