Merge pull request The-OpenROAD-Project#9416 from gadfort/ifp-error

ifp: create error when no rows are created for any sites

Author: gadfort

src/ifp/src/InitFloorplan.cc

@@ -681,7 +681,7 @@ void InitFloorplan::makeUniformRows(odb::dbSite* base_site,
   const uint32_t site_dx = base_site->getWidth();
   const int rows_x = core_dx / site_dx;
 
-  auto make_rows = [&](dbSite* site) {
+  auto make_rows = [&](dbSite* site) -> int {
     const uint32_t site_dy = site->getHeight();
     int rows_y = core_dy / site_dy;
     bool flip = flipped_sites.find(site) != flipped_sites.end();
@@ -716,13 +716,20 @@ void InitFloorplan::makeUniformRows(odb::dbSite* base_site,
                     site_dx);
       y += site_dy;
     }
-    logger_->info(IFP,
-                  1,
-                  "Added {} rows of {} site {}.",
-                  rows_y,
-                  rows_x,
-                  site->getName());
+    if (rows_y == 0) {
+      logger_->warn(IFP, 61, "No rows created for site {}.", site->getName());
+    } else {
+      logger_->info(IFP,
+                    1,
+                    "Added {} rows of {} site {}.",
+                    rows_y,
+                    rows_x,
+                    site->getName());
+    }
+    return rows_y;
   };
+
+  int total_rows = 0;
   for (const auto& [name, site] : sites_by_name) {
     if (site->getHeight() % base_site->getHeight() != 0) {
       logger_->error(
@@ -734,9 +741,13 @@ void InitFloorplan::makeUniformRows(odb::dbSite* base_site,
           base_site->getName(),
           block_->dbuToMicrons(base_site->getHeight()));
     }
-    make_rows(site);
+    total_rows += make_rows(site);
   }
   block_->setCoreArea(block_->computeCoreArea());
+
+  if (total_rows == 0) {
+    logger_->error(IFP, 65, "No rows created in the core area.");
+  }
 }
 
 int InitFloorplan::getOffset(dbSite* base_hybrid_site,

src/ifp/test/BUILD

@@ -19,6 +19,7 @@ COMPULSORY_TESTS = [
     "init_floorplan9",
     "init_floorplan10",
     "init_floorplan11",
+    "init_floorplan12",
     "init_floorplan_dbl_row",
     "init_floorplan_even_rows",
     "init_floorplan_flip_sites",

src/ifp/test/CMakeLists.txt

@@ -14,6 +14,7 @@ or_integration_tests(
     init_floorplan9
     init_floorplan10
     init_floorplan11
+    init_floorplan12
     init_floorplan_dbl_row
     init_floorplan_even_rows
     init_floorplan_flip_sites

src/ifp/test/init_floorplan12.ok

@@ -0,0 +1,5 @@
+[INFO ODB-0227] LEF file: Nangate45/Nangate45.lef, created 22 layers, 27 vias, 135 library cells
+[WARNING IFP-0028] Core area lower left (1.000, 1.000) snapped to (1.140, 1.400).
+[WARNING IFP-0061] No rows created for site FreePDK45_38x28_10R_NP_162NW_34O.
+[ERROR IFP-0065] No rows created in the core area.
+IFP-0065

src/ifp/test/init_floorplan12.tcl

@@ -0,0 +1,14 @@
+# init_floorplan
+source "helpers.tcl"
+read_lef Nangate45/Nangate45.lef
+read_liberty Nangate45/Nangate45_typ.lib
+read_verilog reg1.v
+link_design top
+
+catch {
+  initialize_floorplan -utilization 99 \
+    -aspect_ratio 0.2 \
+    -core_space 1 \
+    -site FreePDK45_38x28_10R_NP_162NW_34O
+} err
+puts $err