Skip to content

Commit 765400d

Browse files
committed
upf: change variables names and warn message
Signed-off-by: Lucas Yuki Imamura <lucasyuki@yahoo.com.br>
1 parent b31098a commit 765400d

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

src/upf/src/upf.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -646,8 +646,8 @@ static bool find_smallest_isolation(sta::dbNetwork* network,
646646
// Search for the most appropriate isolation cell
647647
float smallest_area = std::numeric_limits<float>::max();
648648

649-
for (auto&& iso : iso_cells) {
650-
sta::Cell* masterCell = network->dbToSta(iso);
649+
for (auto&& iso_cell : iso_cells) {
650+
sta::Cell* masterCell = network->dbToSta(iso_cell);
651651
sta::LibertyCell* libertyCell = network->libertyCell(masterCell);
652652

653653
// Find enable & data pins for the isolation cell
@@ -657,7 +657,7 @@ static bool find_smallest_isolation(sta::dbNetwork* network,
657657
odb::dbMTerm* tmp_data_term = nullptr;
658658
odb::dbMTerm* tmp_output_term = nullptr;
659659

660-
for (auto&& term : iso->getMTerms()) {
660+
for (auto&& term : iso_cell->getMTerms()) {
661661
sta::LibertyPort* lib_port
662662
= libertyCell->findLibertyPort(term->getName().c_str());
663663

@@ -714,7 +714,7 @@ static bool find_smallest_isolation(sta::dbNetwork* network,
714714

715715
if (tmp_area < smallest_area) {
716716
smallest_area = tmp_area;
717-
smallest_iso_m = iso;
717+
smallest_iso_m = iso_cell;
718718
enable_term = tmp_enable_term;
719719
data_term = tmp_data_term;
720720
output_term = tmp_output_term;
@@ -1000,7 +1000,11 @@ static bool isolate_connection(odb::dbITerm* src_term,
10001000
odb::dbMTerm *input_m = nullptr, *output_m = nullptr;
10011001
bool inverter_found
10021002
= find_smallest_inverter(network, block, inverter_m, input_m, output_m);
1003-
1003+
1004+
if (!inverter_found) {
1005+
logger->warn(utl::UPF, 31, "can't find any inverters");
1006+
}
1007+
10041008
odb::dbMTerm* enable_term = nullptr;
10051009
odb::dbMTerm* data_term = nullptr;
10061010
odb::dbMTerm* output_term = nullptr;
@@ -1020,11 +1024,6 @@ static bool isolate_connection(odb::dbITerm* src_term,
10201024
return false;
10211025
}
10221026

1023-
if ((invert_output || invert_control) && !inverter_found) {
1024-
logger->warn(utl::UPF, 31, "can't find any inverters");
1025-
return false;
1026-
}
1027-
10281027
return isolate_port(logger,
10291028
block,
10301029
src_inst,

0 commit comments

Comments
 (0)