Merge pull request The-OpenROAD-Project#9274 from rafaelmoresco/symmetry

dpl: add LEF symmetry to dpl and dpo

Author: maliberty

src/dpl/include/dpl/Opendp.h

@@ -198,6 +198,7 @@ class Opendp
                    GridY y,
                    GridX x_end,
                    GridY y_end) const;
+  bool checkMasterSym(unsigned masterSym, unsigned cellOri) const;
   bool shiftMove(Node* cell);
   bool mapMove(Node* cell);
   bool mapMove(Node* cell, const GridPt& grid_pt);

src/dpl/src/Place.cpp

@@ -31,7 +31,9 @@
 #include "odb/db.h"
 #include "odb/dbTransform.h"
 #include "odb/geom.h"
+#include "optimization/detailed_orient.h"
 #include "util/journal.h"
+#include "util/symmetry.h"
 #include "utl/Logger.h"
 // #define ODP_DEBUG
 
@@ -55,6 +57,7 @@ std::string Opendp::printBgBox(
                      queryBox.max_corner().x(),
                      queryBox.max_corner().y());
 }
+
 void Opendp::detailedPlacement()
 {
   if (debug_observer_) {
@@ -1011,9 +1014,41 @@ bool Opendp::checkPixels(const Node* cell,
   }
 
   const auto orient = grid_->getSiteOrientation(x, y, site).value();
+
+  // Check for symmetry
+  auto* dbMaster = cell->getDbInst()->getMaster();
+  unsigned masterSym = dpl::DetailedOrient::getMasterSymmetry(dbMaster);
+  if (!checkMasterSym(masterSym, orient)) {
+    return false;
+  }
+
   return drc_engine_->checkDRC(cell, x, y, orient);
 }
 
+bool Opendp::checkMasterSym(unsigned masterSym, unsigned cellOri) const
+{
+  using odb::dbOrientType;
+  switch (cellOri) {
+    case dbOrientType::R0:
+      return true;
+    case dbOrientType::MX:
+      return (masterSym & Symmetry_X) != 0;
+    case dbOrientType::MY:
+      return (masterSym & Symmetry_Y) != 0;
+    case dbOrientType::R180:
+      return (masterSym & Symmetry_X) && (masterSym & Symmetry_Y);
+    case dbOrientType::R90:
+    case dbOrientType::R270:
+      return (masterSym & Symmetry_ROT90) != 0;
+    case dbOrientType::MXR90:
+    case dbOrientType::MYR90:
+      return (masterSym & Symmetry_ROT90) && (masterSym & Symmetry_X)
+             && (masterSym & Symmetry_Y);
+    default:
+      return false;
+  }
+}
+
 ////////////////////////////////////////////////////////////////
 
 // Legalize cell origin

src/dpl/src/optimization/detailed_manager.cxx

@@ -24,13 +24,33 @@
 #include "odb/dbTransform.h"
 #include "odb/geom.h"
 #include "util/journal.h"
+#include "util/symmetry.h"
 #include "util/utility.h"
 #include "utl/Logger.h"
 
 using utl::DPL;
 
 namespace dpl {
 
+// Helper to check if a cell's master allows the orientation required by the row
+static bool checkMasterSymmetry(Architecture* arch, const Node* nd, int rowId)
+{
+  const auto* rowPtr = arch->getRow(rowId);
+  const unsigned rowOri = rowPtr->getOrient();
+
+  auto* dbMaster = nd->getDbInst()->getMaster();
+  unsigned masterSym = DetailedOrient::getMasterSymmetry(dbMaster);
+
+  using odb::dbOrientType;
+  if (rowOri == dbOrientType::R0 || rowOri == dbOrientType::MY) {
+    return true;
+  }
+  if (rowOri == dbOrientType::MX || rowOri == dbOrientType::R180) {
+    return (masterSym & Symmetry_X) != 0;
+  }
+  return false;
+}
+
 DetailedMgr::DetailedMgr(Architecture* arch,
                          Network* network,
                          Grid* grid,
@@ -512,6 +532,9 @@ DetailedSeg* DetailedMgr::findClosestSegment(const Node* nd)
     if (nd->getGroupId() != curr->getRegId()) {
       continue;
     }
+    if (!checkMasterSymmetry(arch_, nd, curr->getRowId())) {
+      continue;
+    }
 
     // Work with left edge.
     const DbuX x1 = curr->getMinX();
@@ -551,6 +574,9 @@ DetailedSeg* DetailedMgr::findClosestSegment(const Node* nd)
           if (nd->getGroupId() != curr->getRegId()) {
             continue;
           }
+          if (!checkMasterSymmetry(arch_, nd, curr->getRowId())) {
+            continue;
+          }
 
           // Work with left edge.
           const DbuX x1 = curr->getMinX();
@@ -591,6 +617,9 @@ DetailedSeg* DetailedMgr::findClosestSegment(const Node* nd)
           if (nd->getGroupId() != curr->getRegId()) {
             continue;
           }
+          if (!checkMasterSymmetry(arch_, nd, curr->getRowId())) {
+            continue;
+          }
 
           // Work with left edge.
           const DbuX x1 = curr->getMinX();
@@ -698,6 +727,10 @@ bool DetailedMgr::findClosestSpanOfSegments(Node* nd,
       continue;
     }
 
+    if (!checkMasterSymmetry(arch_, nd, r)) {
+      continue;
+    }
+
     // Scan the segments in this row and look for segments in the required
     // number of rows above and below that result in non-zero interval.
     const int b = r;
@@ -2193,6 +2226,11 @@ bool DetailedMgr::tryMove(Node* ndi,
 {
   // Based on the input, call an appropriate routine to try
   // and generate a move.
+  if (!checkMasterSymmetry(arch_, ndi, segments_[sj]->getRowId())) {
+    rejectMove();
+    return false;
+  }
+
   if (arch_->getCellHeightInRows(ndi) == 1) {
     // Single height cell.
     if (si != sj) {
@@ -2227,6 +2265,10 @@ bool DetailedMgr::trySwap(Node* ndi,
                           const DbuY yj,
                           const int sj)
 {
+  if (!checkMasterSymmetry(arch_, ndi, segments_[sj]->getRowId())) {
+    rejectMove();
+    return false;
+  }
   if (trySwap1(ndi, xi, yi, si, xj, yj, sj)) {
     return verifyMove();
   }
@@ -2702,6 +2744,10 @@ bool DetailedMgr::trySwap1(Node* ndi,
   if (ndj == ndi || ndj == nullptr) {
     return false;
   }
+  if (!checkMasterSymmetry(arch_, ndj, segments_[si]->getRowId())) {
+    return false;
+  }
+
   if (arch_->getCellHeightInRows(ndi) != 1
       || arch_->getCellHeightInRows(ndj) != 1) {
     return false;