fixes after review

Author: magnurud

lascli/parser/datasets.py

@@ -321,7 +321,7 @@ def create_documents(
     return dict(counter)
 
 
-def get_documents(las_client: Client, dataset_id, output_dir, num_threads, chunk_size, max_elements):
+def get_documents(las_client: Client, dataset_id, output_dir, num_threads, chunk_size, max_results):
     already_downloaded = set()
     if output_dir.exists():
         for path in output_dir.iterdir():
@@ -337,7 +337,7 @@ def get_documents(las_client: Client, dataset_id, output_dir, num_threads, chunk
                 already_downloaded_from_dataset.add(document['documentId'])
             else:
                 documents.append(document)
-            if max_elements and max_elements <= len(documents):
+            if max_results and max_results <= len(documents):
                 break
         print(f'Found {len(already_downloaded_from_dataset)} documents already downloaded')
 
@@ -470,7 +470,7 @@ def create_datasets_parser(subparsers):
     get_documents_parser.add_argument('output_dir', type=Path, help='Path to download directory')
     get_documents_parser.add_argument('--num-threads', default=32, type=int, help='Number of threads to use')
     get_documents_parser.add_argument('--chunk-size', default=100, type=int)
-    get_documents_parser.add_argument('--max-elements', default=0, type=int)
+    get_documents_parser.add_argument('--max-results', default=0, type=int)
     get_documents_parser.set_defaults(cmd=get_documents)
 
     create_transformation_parser = subparsers.add_parser('create-transformation')
@@ -483,7 +483,7 @@ def create_datasets_parser(subparsers):
               "options": {}                                       (optional)
           },
           ...
-        ]  
+        ]
         Examples:
         [{"type": "remove-duplicates", "options": {}}]
     '''))

lascli/parser/predictions.py

@@ -8,6 +8,7 @@
 
 
 def create_prediction(las_client: Client, document_id, model_id, **optional_args):
+    optional_args['run_async'] = optional_args.pop('async', None)
     return las_client.create_prediction(document_id, model_id, **optional_args)
 
 
@@ -55,7 +56,7 @@ def create_predictions_parser(subparsers):
         {"strategy": "BEST_N_PAGES", "parameters": {"n": 3}}
         {"strategy": "BEST_N_PAGES", "parameters": {"n": 3, "collapse": true}}
     '''))
-    create_predicton_parser.add_argument('--run-async', action='store_true', help='Create prediction async')
+    create_predicton_parser.add_argument('--async', action='store_true', help='Create prediction async')
     create_predicton_parser.set_defaults(cmd=create_prediction)
 
     list_predictions_parser = subparsers.add_parser('list')