Help migrating away from CustomMapFunction

[jufa2401]

Hi @lbargaoanu,

In AutoMapper 10.1.1, I am using some code that relies on the member CustomMapFunction on the type PropertyMap.

I cannot find a suitable replacement to make my code work? What would be the equivalent to checking if PropertyMap.CustomMapFunction != null in Automapper 11.*+?

[lbargaoanu]

The PropertyMap would have a resolver of type FuncResolver.

[jufa2401]

Value cannot be null. (Parameter 'property')
   at System.Linq.Expressions.Expression.Property(Expression expression, PropertyInfo property)
   at AutoMapper.Execution.ExpressionBuilder.Property(Expression target, String name)
   at AutoMapper.Internal.Mappers.NullableSourceMapper.MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap, MemberMap memberMap, Expression sourceExpression, Expression destExpression)
   at AutoMapper.Execution.ExpressionBuilder.MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap, TypePair typePair, Expression source, MemberMap memberMap, Expression destination)

[lbargaoanu]

It seems to me like you have some code that doesn't work :) That mapper seems to work just fine.

[jufa2401]

I understand, but there must be some differences to the NullableSourceMapper of 8.0.* that breaks this legacy code.

Is there a chance that NullableSourceMapper changed behaviour between 8.0.* and 12.0.* or the usage of NullableSourceMapper changed?

If there are scenarios that you know have changed it would help me find out the bug in this legacy code a lot 😊

[jbogard]

I'm not seeing much here:

https://github.com/AutoMapper/AutoMapper/compare/v8.0.0..v12.0.0#diff-d7e622e51236d54bed3658e689c039326cbc388dda23de08eda84c2f2bc99f5b

[jufa2401]

Basically we had these two block running as part of our IMapperConfigurationExpression and when we update to later versions of AutoMapper significant functionality breaks.

We have unfortunately built a lot of feature on top of these configurations, so it's difficult for me to both change and update, and the original intent is questionable.

    public static void MapToSelf(this IMapperConfigurationExpression cfg)
    {
        cfg.ForAllPropertyMaps(
            pm => {
                if (pm.DestinationType == null) {
                    return false;
                }

                if (pm.SourceType == null) {
                    return false;
                }

                if (pm.TypeMap.DestinationType != pm.TypeMap.SourceType) {
                    return false;
                }

                return true;
            },
            (pm, c) => c.Condition((src, dest, srcMember) => srcMember != null)
        );
    }

    public static void IgnoreSourceWhenNull(this IMapperConfigurationExpression cfg)
    {
        cfg.ForAllPropertyMaps(
            pm => {
                if (pm.CustomMapExpression != null || pm.CustomMapFunction != null) {
                    return false;
                }

                if (pm.Ignored) {
                    return false;
                }

                if (!pm.CanResolveValue) {
                    return false;
                }

                if (pm.DestinationType == null) {
                    return false;
                }

                if (pm.SourceType == null) {
                    return false;
                }

                var isNullable = pm.SourceType.IsGenericType && pm.SourceType.GetGenericTypeDefinition() == typeof(Nullable<>);
                return isNullable || pm.SourceType.IsClass || pm.SourceType.IsInterface;
            },
            (pm, c) => c.MapFrom(new Resolver(pm.SourceType, pm.DestinationType), pm.SourceMember.Name)
        );
    }

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed.