use hashset instead vectors

Author: LuisLiraC

src/main.rs

@@ -1,10 +1,11 @@
 use git2::Repository;
+use std::collections::HashSet;
 use std::env;
 use glob::Pattern;
 use std::process::Command;
 use std::time::Instant;
 
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 struct PatternFilter {
     pattern: String,
     exclude: bool,
@@ -32,13 +33,18 @@ fn main() {
     let duration = start.elapsed();
     println!("Getting changed files done in: {:?}", duration);
 
+    println!("Changed files: {:?}", changed_files);
+
     let start = Instant::now();
     let filtered_files = filter(changed_files, include_patterns_filters, exclude_patterns_filters);
     let duration = start.elapsed();
     println!("Filtering files done in: {:?}", duration);
 
     let count = get_count(filtered_files.clone());
 
+    println!("Filtered files: {:?}", filtered_files);
+    println!("Count: {}", count);
+
     Command::new("sh")
         .arg("-c")
         .arg(format!("echo \"DIFF_FILES={:?}\" >> $GITHUB_OUTPUT", filtered_files))
@@ -53,10 +59,17 @@ fn main() {
 }
 
 fn create_patterns_filters(arg: &str) -> Vec<PatternFilter> {
-    let patterns = arg
+    let binding = arg
         .split('=')
         .last()
         .expect("Failed to get patterns")
+        .replace(" ", "")
+        .replace("\n", ",")
+        .replace("\r", "")
+        .replace(",,", ",")
+        .to_string();
+
+    let patterns = binding
         .split(',')
         .collect::<Vec<&str>>();
 
@@ -120,13 +133,16 @@ fn get_changed_files() -> Vec<String> {
     changed_files
 }
 
-fn filter(changed_files: Vec<String>, include_patterns_filters: Vec<PatternFilter>, exclude_patterns_filters: Vec<PatternFilter>) -> Vec<String> {
+fn filter(changed_files: Vec<String>, include_patterns_filters: Vec<PatternFilter>, exclude_patterns_filters: Vec<PatternFilter>) -> HashSet<String> {
     let filtered_files: Vec<String> = include_patterns_filters
         .iter()
         .flat_map(|pattern| filter_files_by_pattern(pattern, &changed_files, &exclude_patterns_filters))
         .collect();
 
-    filtered_files
+    let mut hash_set_filtered_files = HashSet::new();
+    hash_set_filtered_files.extend(filtered_files.clone());
+
+    hash_set_filtered_files
 }
 
 fn filter_files_by_pattern(pattern_filter: &PatternFilter, files: &Vec<String>, exclude_patterns: &Vec<PatternFilter>) -> Vec<String> {
@@ -150,7 +166,7 @@ fn filter_files_by_pattern(pattern_filter: &PatternFilter, files: &Vec<String>,
     filtered_files
 }
 
-fn get_count(filtered_files: Vec<String>) -> usize {
+fn get_count(filtered_files: HashSet<String>) -> usize {
     filtered_files.len()
 }
 

src/tests/integration.rs

@@ -8,7 +8,7 @@ mod integration {
     fn test_filter() {
         let arg = "--patterns=*.rs,!*..txt";
         let files = vec![
-            String::from("main.rs"),
+            String::from("src/main.rs"),
             String::from("lib.rs"),
             String::from("test.txt"),
         ];
@@ -21,10 +21,12 @@ mod integration {
 
         let count = get_count(filtered_files.clone());
 
-        assert_eq!(
-            filtered_files,
-            vec![String::from("main.rs"), String::from("lib.rs")]
-        );
+        let expected_filtered_files = HashSet::from([
+            String::from("src/main.rs"),
+            String::from("lib.rs"),
+        ]);
+
+        assert_eq!(filtered_files, expected_filtered_files);
         assert_eq!(count, 2);
     }
 }

src/tests/unit.rs

@@ -40,7 +40,7 @@ mod unit {
     #[test]
     fn test_filter() {
         let files = vec![
-            String::from("main.rs"),
+            String::from("src/main.rs"),
             String::from("lib.rs"),
             String::from("test.txt"),
         ];
@@ -49,6 +49,10 @@ mod unit {
                 pattern: String::from("*.rs"),
                 exclude: false,
             },
+            PatternFilter {
+                pattern: String::from("src/**"),
+                exclude: false,
+            },
             PatternFilter {
                 pattern: String::from("*.txt"),
                 exclude: false,
@@ -59,10 +63,12 @@ mod unit {
             exclude: true,
         }];
         let filtered_files = filter(files, include_patterns_filters, exclude_patterns_filters);
-        assert_eq!(
-            filtered_files,
-            vec![String::from("main.rs"), String::from("lib.rs")]
-        );
+        let expected_filtered_files = HashSet::from([
+            String::from("src/main.rs"),
+            String::from("lib.rs"),
+        ]);
+
+        assert_eq!(filtered_files, expected_filtered_files);
     }
 
     #[test]
@@ -123,11 +129,11 @@ mod unit {
 
     #[test]
     fn test_get_count() {
-        let files = vec![
+        let files = HashSet::from([
             String::from("main.rs"),
             String::from("lib.rs"),
             String::from("version.txt"),
-        ];
+        ]);
         let count = get_count(files);
         assert_eq!(count, 3);
     }